Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next-build Manila: Facility sidebar menus should show #19762

Open
1 task
timcosgrove opened this issue Nov 4, 2024 · 3 comments
Open
1 task

Next-build Manila: Facility sidebar menus should show #19762

timcosgrove opened this issue Nov 4, 2024 · 3 comments
Labels
Accelerated Publishing Events product maintained by Public Websites team Facilities Facilities products (VAMC, Vet Center, etc) Left sidenav Drupal Menu-driven left navigation that appears throughout VA.gov Needs refining Issue status News release CMS managed product owned by Facilities team next-build FE Repository that will replace content-build. Uses NextJS, builds static pages. Story CMS managed product owned by Facilities team VA Manila Special case VAMC that has custom code implementation VAMC CMS managed product owned by Facilities team

Comments

@timcosgrove
Copy link
Contributor

timcosgrove commented Nov 4, 2024

Requirements

We want the facility sidebar to show in Manila Clinic pages built by Next Build so that users can navigate to other pages.

This includes:

  • Event pages
  • Story pages
  • News release pages

Acceptance criteria

Preview Give feedback

Background & implementation details

In #18931, a decision was made to keep VAMC System unpublished for the Manila Clinic system, and to use a VAMC Facility as the base page of that system.

The problem with this for Next Build is that several pages get their menu through the VAMC System page. These pages have a field_office which points to VAMC System, and VAMC System in turn has a reference to the menu for that system. Since the Manila VAMC System is unpublished, we cannot get the menus this way.

The solution could be

  • changes to how Next Build finds menus
  • working with the Facilities team to make Manila's content data structure consistent with other systems while preserving the IA requirements of the Manila system.
@gracekretschmer-metrostar gracekretschmer-metrostar added the next-build FE Repository that will replace content-build. Uses NextJS, builds static pages. label Nov 4, 2024
@jilladams
Copy link
Contributor

Changes from #19570 are now complete and in Prod. This means in content-build land, Manila editor could be given the greenlight to create Events. However: with events shipping in AP next week, we won't provide that instruction til we hear from you all after launch, and about the destiny of this ticket. If you wouldn't mind keeping me / @Agile6MSkinner in the loop?

@jilladams jilladams added Events product maintained by Public Websites team Story CMS managed product owned by Facilities team News release CMS managed product owned by Facilities team VA Manila Special case VAMC that has custom code implementation labels Nov 29, 2024
@jilladams
Copy link
Contributor

@timcosgrove for awareness there's another ticket we filed about a weird thing with the Leadership link not using the right URL from the sidenav on Staff profile pages for Manila either. I think that's just a content-build logic thing we'll need to sort, not AP related at this stage, but FYI in case it also needs to be considered here in AP:

@jilladams
Copy link
Contributor

Because I just got confused, I made a table to prevent my own future confusion. The listed Tugboat is this one: https://tugboat.vfs.va.gov/6749f5a1e2b213c935a1c93b

Content type Prod other VAMC Content-build Manila (Tugboat) Next-build Manila
Event Listing Left sidenav MN Left sidenav Tugboat Template is built. No left sidenav yet, but needs it 🔴
Event No left sidenav Minn example No left sidenav Tug No left sidenav 🟢
Story listing Left sidenav MN Left sidenav Tug Template is built. No left sidenav yet, but needs it 🔴
Story No left sidenav MN No left nav Tug Template in progress, IIR
News Release listing Left sidenav MN Left nav Tug Template in progress, IIR
News Release No left sidenav MN No left sidenav Tug Template in progress, IIR
Leadership List Left sidenav MN Left sidenav Tug Template is not built.
Staff Profile Only Leadership link MN Only leadership link Tug Template is not built.

@jilladams jilladams added the Left sidenav Drupal Menu-driven left navigation that appears throughout VA.gov label Dec 10, 2024
@jilladams jilladams marked this as a duplicate of #20144 Dec 23, 2024
@jilladams jilladams added Facilities Facilities products (VAMC, Vet Center, etc) VAMC CMS managed product owned by Facilities team labels Dec 23, 2024
@jilladams jilladams changed the title Facility sidebar menus should show in Manila Clinic pages Next-build Manila: Facility sidebar menus should show Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accelerated Publishing Events product maintained by Public Websites team Facilities Facilities products (VAMC, Vet Center, etc) Left sidenav Drupal Menu-driven left navigation that appears throughout VA.gov Needs refining Issue status News release CMS managed product owned by Facilities team next-build FE Repository that will replace content-build. Uses NextJS, builds static pages. Story CMS managed product owned by Facilities team VA Manila Special case VAMC that has custom code implementation VAMC CMS managed product owned by Facilities team
Projects
None yet
Development

No branches or pull requests

3 participants