-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FE: Display Vet Center Banner Image on Facility Pages #18711
Comments
The interface is the GraphQL, it will just add something for the field they wire up to say like:
or something, depending on the sizes/configuration. |
Hey team! Please add your planning poker estimate with Zenhub @eselkin @jv-agile6 @chriskim2311 @randimays @dsasser |
@Agile6MSkinner I just noticed that the design system has something to say about logos:
I know there have already been design reviews for this change, so maybe I'm misinterpreting the meaning of "custom logo". |
Interesting point, @dsasser. @aklausmeier any thoughts on that? |
I put a caveat on the example GQL query. |
@Agile6MSkinner We have an exception to use the Vet Center logo by someone on the web governance board IF it becomes the final design. The design is still in iterations and the logo has potential to be revised to an image. In my view this ticket is blocked by design. |
@Agile6MSkinner Should this be in the Ready column? Looks like it is still blocked by the Drupal ticket. |
Will wait on determination of image status for Monday |
@eselkin the image annotations have been finalized. The image will be contextual and I have added the approved alt text into Drupal already |
From planning:
|
Verified on prod: https://www.va.gov/evanston-vet-center/ |
Description
As a veteran who lands on a Vet Center facility page, I would like a VetCenter-specific banner imageto be prominently displayed at the top of the page so that I recognize it as something distinct from other VAMC facilities.
Figma Designs
Image will be added to Drupal in #18709
Implementation Details
The interface for fetching the Vet Center banner image
will utilize GraphQL. The query will be configured to retrieve the necessary fields for displaying the logo appropriately across various device breakpoints.
Example GraphQL query configuration (DO NOT use this verbatim, we do not know what the field is yet and it may come in a different format due to Centralized Content):
QA
Acceptance Criteria
The text was updated successfully, but these errors were encountered: