Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE: Display Vet Center Banner Image on Facility Pages #18711

Closed
4 tasks
Agile6MSkinner opened this issue Jul 22, 2024 · 12 comments
Closed
4 tasks

FE: Display Vet Center Banner Image on Facility Pages #18711

Agile6MSkinner opened this issue Jul 22, 2024 · 12 comments
Assignees
Labels
Blocked Issues that are blocked on factors other than blocking issues. Facilities Facilities products (VAMC, Vet Center, etc) sitewide VA.gov frontend CMS team practice area Vet Center CMS managed product owned by Facilities team

Comments

@Agile6MSkinner
Copy link

Agile6MSkinner commented Jul 22, 2024

Description

As a veteran who lands on a Vet Center facility page, I would like a VetCenter-specific banner imageto be prominently displayed at the top of the page so that I recognize it as something distinct from other VAMC facilities.

Figma Designs

Image will be added to Drupal in #18709

Implementation Details

The interface for fetching the Vet Center banner image

will utilize GraphQL. The query will be configured to retrieve the necessary fields for displaying the logo appropriately across various device breakpoints.

Example GraphQL query configuration (DO NOT use this verbatim, we do not know what the field is yet and it may come in a different format due to Centralized Content):

fieldVetCenterCCGraphic {
   entity {
        ... on MediaImage {
          image {
            alt
            title
            derivative(style: _32MEDIUMTHUMBNAIL) {
                url
                width
                height
            }
          }
        }
    }
}

QA

Preview Give feedback

Acceptance Criteria

  • Create a GraphQL query to fetch the Vet Center banner image from the centralized content in Drupal.
  • Banner image is presented on Vet Center pages
  • Implement responsive breakpoints for the banner image
  • Follow all annotations in linked Figma designs
@Agile6MSkinner Agile6MSkinner added Facilities Facilities products (VAMC, Vet Center, etc) sitewide Vet Center CMS managed product owned by Facilities team labels Jul 22, 2024
@eselkin
Copy link
Contributor

eselkin commented Jul 23, 2024

The interface is the GraphQL, it will just add something for the field they wire up to say like:

fieldVetCenterCCGraphic {
   entity {
        ... on MediaImage {
          image {
            alt
            title
            derivative(style: _32MEDIUMTHUMBNAIL) {
                url
                width
                height
            }
          }
        }
}

or something, depending on the sizes/configuration.

@Agile6MSkinner
Copy link
Author

@dsasser
Copy link
Contributor

dsasser commented Jul 23, 2024

@Agile6MSkinner I just noticed that the design system has something to say about logos:

Using custom logos for VA departments, offices, teams, sub-groups, special programs, initiatives, or events is not supported on VA.gov. This practice aligns with the requirements in the VA Graphic Standards and the Web Governance site.

I know there have already been design reviews for this change, so maybe I'm misinterpreting the meaning of "custom logo".

@Agile6MSkinner
Copy link
Author

Interesting point, @dsasser. @aklausmeier any thoughts on that?

@Agile6MSkinner Agile6MSkinner added the VA.gov frontend CMS team practice area label Jul 23, 2024
@eselkin
Copy link
Contributor

eselkin commented Jul 23, 2024

I put a caveat on the example GQL query.

@aklausmeier
Copy link

@Agile6MSkinner We have an exception to use the Vet Center logo by someone on the web governance board IF it becomes the final design. The design is still in iterations and the logo has potential to be revised to an image. In my view this ticket is blocked by design.

@Agile6MSkinner Agile6MSkinner changed the title Display Vet Center Logo on Facility Pages Display Vet Center Banner Image on Facility Pages Aug 5, 2024
@randimays
Copy link
Contributor

@Agile6MSkinner Should this be in the Ready column? Looks like it is still blocked by the Drupal ticket.

@Agile6MSkinner
Copy link
Author

Agile6MSkinner commented Aug 5, 2024

It has been refined, so the story is ready, but it has a dependency that's listed:
image

When looking at the board, it shows which tickets are blocked or blocking with these icons:
image

@jilladams jilladams added the Blocked Issues that are blocked on factors other than blocking issues. label Aug 7, 2024
@jilladams jilladams changed the title Display Vet Center Banner Image on Facility Pages FE: Display Vet Center Banner Image on Facility Pages Aug 16, 2024
@eselkin eselkin self-assigned this Aug 22, 2024
@eselkin
Copy link
Contributor

eselkin commented Aug 22, 2024

Will wait on determination of image status for Monday

@laflannery
Copy link
Contributor

@eselkin the image annotations have been finalized. The image will be contextual and I have added the approved alt text into Drupal already

@jilladams
Copy link
Contributor

From planning:

  • Image is still in Vet Center centralized Content
  • FE will hard code, referencing that image
  • Michelle isn't concerned about confusing Natl staff, as they are not likely to try and edit the image.
  • We can leave it this way for now and iterate in future if needed.

@davidmpickett
Copy link
Contributor

Verified on prod: https://www.va.gov/evanston-vet-center/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Issues that are blocked on factors other than blocking issues. Facilities Facilities products (VAMC, Vet Center, etc) sitewide VA.gov frontend CMS team practice area Vet Center CMS managed product owned by Facilities team
Projects
None yet
Development

No branches or pull requests

8 participants