LH V0: Deprecate the /v1/facilities/va endpoint in vets-api

[jilladams]

[2024-10-30] We cannot deprecate the whole legacy API client til we hear from Don (McCaughey?) on the mobile team. BUT: we may be able to deprecate this endpoint.

Description or Additional Context

Context: #18351

Should decommission and remove not the library but the endpoint for /v1/facilities/va

The legacy Facilities API client/library in vets-api has an active endpoint that references Lighthouse V0. We need to deprecate that, now that LH V0 has been deprecated

The legacy API client is very minimally documented here: https://github.com/department-of-veterans-affairs/va.gov-team/tree/master/products/facilities/facilities-api#legacy-facilities-api-client

The code lives here: https://github.com/department-of-veterans-affairs/vets-api/tree/master/lib/lighthouse/facilities

Acceptance Criteria

• /v1/facilities/va endpoint is no longer available in vets-api

[jilladams]

We may find ourselves blocked from removing htis endpoint, depending on how Mobile handled the legacy API client V1 upgrade. But Eli will check, and if it can be removed, we will.

[eselkin]

The endpoint could be removed without touching the library stuff that the Mobile team modified.

[jilladams]

@eselkin how can we verify this in order to close?

[eselkin]

If you go to https://api.va.gov/v1/facilities/va/vha_648 you should get a 404.
The 404 should look like
{"errors":[{"title":"Not found","detail":"There are no routes matching your request: v1facilities/v1/va/vha_648","code":"411","status":"404"}]}
Whereas if you go to:
https://api.va.gov/facilities_api/v2/va/vha_648
you should get a result.

[jilladams]

Verified! Closing.