Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When VAMC Health Services are created, the revision timestamp on related VAMC Facility is incorrect #17808

Open
1 task
jilladams opened this issue Apr 10, 2024 · 3 comments
Labels
Defect Something isn't working (issue type) Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status Regional office CMS managed VBA product owned by the Facilities team sitewide Technical debt VA services taxonomy CMS-managed product owned by the Facilities team VAMC CMS managed product owned by Facilities team

Comments

@jilladams
Copy link
Contributor

jilladams commented Apr 10, 2024

Description or Additional Context

In the aftermath of #17587, we have a new regression, circling around March 2, 2024, 7:28 am. (CT)

Expected behavior

When a new VAMC Facility Health service is created, it is associated with a VAMC Facility. That related VAMC Facility should get a Revision log for the creation timestamp. This should happen when a new service is created related to the VAMC Facility, by way of the corresponding entity reference.

Current behavior in prod

When a new VAMC Facility Health Service is created, we suspect that it is somehow bypassing the normal process and is using the timestamp of the previous node revision rather than creating a new revision / timestamp.

Updated date not matching the revision log

Content view (/admin/content)

Palm Bay VA Clinic was updated on April 8, 2024

Screenshot 2024-04-10 at 17 42 17

Recent changes

No April 8 revision is shown.
Screenshot 2024-04-10 at 17 42 35

Comparing revisions

The only difference is the addition of a health service.
Screenshot 2024-04-10 at 17 43 28

VAMC facility health service creation

The time at which the health service was created is the same time at which /admin/content lists the facility as being updated. The facility is updated when a new service is created that is related to it by way of the corresponding entity reference.

Screenshot 2024-04-10 at 17 50 17

Acceptance Criteria

  • New revision logs should use the current timestamp across all products that use VA Services
@jilladams jilladams added VAMC CMS managed product owned by Facilities team Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status VA services taxonomy CMS-managed product owned by the Facilities team Defect Something isn't working (issue type) Technical debt labels Apr 10, 2024
@jilladams
Copy link
Contributor Author

@omahane is this sort of the same issue, but for Vet Centers? #15125

@jilladams
Copy link
Contributor Author

THis might also be true for VBA.

@jilladams jilladams added the Regional office CMS managed VBA product owned by the Facilities team label Apr 15, 2024
@jilladams
Copy link
Contributor Author

May also apply to Vet Center services in the world after removing the inline entity form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Something isn't working (issue type) Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status Regional office CMS managed VBA product owned by the Facilities team sitewide Technical debt VA services taxonomy CMS-managed product owned by the Facilities team VAMC CMS managed product owned by Facilities team
Projects
None yet
Development

No branches or pull requests

1 participant