Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BLOCKED] [CCP] (#2) Modify vets-api to handle pagination from CCP PPMS and verify that vets-website facility locator is resolving pagination correctly #17649

Open
5 tasks
eselkin opened this issue Mar 27, 2024 · 4 comments
Labels
Blocked Issues that are blocked on factors other than blocking issues. CY24-Q3 Sitewide Q3 initiatives Facilities API Vets-api API that powers Facilities products and the Facility Locator Facilities Facilities products (VAMC, Vet Center, etc) Facility Locator product owned by Facilities team Fran Cross - PM points-8 sitewide VA.gov frontend CMS team practice area

Comments

@eselkin
Copy link
Contributor

eselkin commented Mar 27, 2024

Status

2024-08-06] Blocked by #17646

User Story or Problem Statement

As a user, I want to see an increasing number of results on CCP searches in facility locator when it is zoomed out on an area with more data. That data should be in a paginated format like lighthouse results.

Description or Additional Context

Steps for Implementation

  1. Modify vets-api pagination to capture page (page, per_page, and total entries) information
  2. Add tests to spec to guarantee pagination works for CCP vets-api endpoint
  3. Verify that vets-website facility locator can page through results from CCP endpoint (it should use the same abstraction for pagination/wrapper as VA endpoints)
  4. Add tests in vets-website to check that facility locator can page through CCP endpoint results.

Acceptance Criteria

  • vets-api should return data with next_page attributes when more than 10 entries
  • vets-api should be able to return subsequent results of CCP search when queries with page > 1
  • vets-website should show multiple pages when total entries greater than 10
  • Requires design review
  • Requires accessibility review
@eselkin eselkin added Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status VA.gov frontend CMS team practice area labels Mar 27, 2024
@jilladams jilladams added the Facility Locator product owned by Facilities team label Mar 29, 2024
@jilladams
Copy link
Contributor

Spike notes: #17418 (comment)

@eselkin eselkin changed the title Modify vets-api to handle pagination from CCP PPMS and verify that facility locator is resolving pagination correctly Modify vets-api and vets-website to handle pagination from CCP PPMS and verify that facility locator is resolving pagination correctly Mar 29, 2024
@eselkin eselkin changed the title Modify vets-api and vets-website to handle pagination from CCP PPMS and verify that facility locator is resolving pagination correctly Modify vets-api to handle pagination from CCP PPMS and verify that vets-website facility locator is resolving pagination correctly Mar 29, 2024
@davidmpickett davidmpickett added CY24-Q2 Calendar year Q2 2024 priority Blocked Issues that are blocked on factors other than blocking issues. and removed Needs refining Issue status labels Apr 11, 2024
@jilladams jilladams added Facilities API Vets-api API that powers Facilities products and the Facility Locator and removed Blocked Issues that are blocked on factors other than blocking issues. labels May 10, 2024
@jilladams
Copy link
Contributor

Calling this blocked until our team gets GFE in order to work on PPMS in vets-api.

@jilladams jilladams added the Blocked Issues that are blocked on factors other than blocking issues. label May 29, 2024
@jilladams
Copy link
Contributor

Noting: I just observed a flipper in prod, facility_locator_restore_community_care_pagination - we should think about this once we take up the pagination effort, and figure out if it's in use / can be deprecated. Related ticket: #11597

@davidmpickett
Copy link
Contributor

@eselkin Is this still blocked, or could it move now?

@FranECross FranECross changed the title Modify vets-api to handle pagination from CCP PPMS and verify that vets-website facility locator is resolving pagination correctly [CCP PPMS] (1) Modify vets-api to handle pagination from CCP PPMS and verify that vets-website facility locator is resolving pagination correctly Aug 6, 2024
@FranECross FranECross changed the title [CCP PPMS] (1) Modify vets-api to handle pagination from CCP PPMS and verify that vets-website facility locator is resolving pagination correctly [CCP PPMS] Modify vets-api to handle pagination from CCP PPMS and verify that vets-website facility locator is resolving pagination correctly Aug 6, 2024
@FranECross FranECross changed the title [CCP PPMS] Modify vets-api to handle pagination from CCP PPMS and verify that vets-website facility locator is resolving pagination correctly [CCP] Modify vets-api to handle pagination from CCP PPMS and verify that vets-website facility locator is resolving pagination correctly Aug 6, 2024
@FranECross FranECross changed the title [CCP] Modify vets-api to handle pagination from CCP PPMS and verify that vets-website facility locator is resolving pagination correctly [CCP] (#2) Modify vets-api to handle pagination from CCP PPMS and verify that vets-website facility locator is resolving pagination correctly Aug 6, 2024
@FranECross FranECross removed the CY24-Q2 Calendar year Q2 2024 priority label Aug 8, 2024
@FranECross FranECross added CY24-Q3 Sitewide Q3 initiatives Fran Cross - PM labels Aug 8, 2024
@FranECross FranECross changed the title [CCP] (#2) Modify vets-api to handle pagination from CCP PPMS and verify that vets-website facility locator is resolving pagination correctly [BLOCKED] [CCP] (#2) Modify vets-api to handle pagination from CCP PPMS and verify that vets-website facility locator is resolving pagination correctly Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Issues that are blocked on factors other than blocking issues. CY24-Q3 Sitewide Q3 initiatives Facilities API Vets-api API that powers Facilities products and the Facility Locator Facilities Facilities products (VAMC, Vet Center, etc) Facility Locator product owned by Facilities team Fran Cross - PM points-8 sitewide VA.gov frontend CMS team practice area
Projects
None yet
Development

No branches or pull requests

4 participants