-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VAMC Policies: adopt V1 components where components are not used #16953
Comments
I estimate this ticket at a 2 for moving many relatively simple elements over to components (almost deja vu). I bumped it down from 3 since it's a simpler page with fewer risks of side effects from changing components. |
Telephone moved to #16148 |
I would rate this a 3 due to the slightly larger scope and the usual risk of breaking tests. |
I imagine a 2, since all the links internal to the page are centralized content or drupal content that cannot be altered in the code currently. |
@laflannery The body content on this page is Drupal content (WYSIWYG blocks), and we can't control the way the links render. I'll still add the Back to Top component on these and adjust the ACs accordingly. |
Thanks @randimays Thats what I thought but just wanted to be sure I didn't miss anything. Thanks for confirming! |
Validated successfully in production. Closing! |
Description
VAMC Policies pages need the following updates to components:
Example pages:
Elements that are not using components that should be (Backlog)
LinkLinks are not using a component but should be using the v1 component if possible, with the understanding thatCMS content has limitations (Randi: confirming here that we can't change the way the CMS content is rendered)TelephoneThe component is not being used anywhere but should be if possible, with the understanding that CMS content has limitationsExts in phone numbers within the component are parsed correctlyAcceptance Criteria
Link component has been addedThe text was updated successfully, but these errors were encountered: