Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAMC Policies: adopt V1 components where components are not used #16953

Closed
5 tasks
laflannery opened this issue Jan 22, 2024 · 7 comments
Closed
5 tasks

VAMC Policies: adopt V1 components where components are not used #16953

laflannery opened this issue Jan 22, 2024 · 7 comments
Assignees
Labels
accessibility Issues related to accessibility CY24-Q2 Calendar year Q2 2024 priority Facilities Facilities products (VAMC, Vet Center, etc) Public Websites Scrum team in the Sitewide crew sitewide VA.gov frontend CMS team practice area VAMC CMS managed product owned by Facilities team

Comments

@laflannery
Copy link
Contributor

laflannery commented Jan 22, 2024

Description

VAMC Policies pages need the following updates to components:

Example pages:

Elements that are not using components that should be (Backlog)

  1. Link
    • Links are not using a component but should be using the v1 component if possible, with the understanding that CMS content has limitations (Randi: confirming here that we can't change the way the CMS content is rendered)
  2. Telephone
    • The component is not being used anywhere but should be if possible, with the understanding that CMS content has limitations
    • Exts in phone numbers within the component are parsed correctly
  3. Back to top component
    • Update 5/3: After determining that this component does not actually have built in intelligence to only show based on page height:
      • This should still be added, the Policies pages are typically longer so having this on these pages will probably make sense more often than not.

Acceptance Criteria

  • Link component has been added
  • Back to top component has been added
  • Update and run existing test(s).
  • If additional tests are needed, stub a ticket to note this for future work.
  • Requires accessibility review
@laflannery laflannery added the Needs refining Issue status label Jan 22, 2024
@laflannery laflannery changed the title Update VAMC Policies with components Update VAMC Policies template with components Jan 22, 2024
@laflannery laflannery added VA.gov frontend CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) accessibility Issues related to accessibility VAMC CMS managed product owned by Facilities team labels Jan 22, 2024
@maxx1128
Copy link

I estimate this ticket at a 2 for moving many relatively simple elements over to components (almost deja vu). I bumped it down from 3 since it's a simpler page with fewer risks of side effects from changing components.

@xiongjaneg xiongjaneg removed the Needs refining Issue status label Feb 28, 2024
@jilladams jilladams changed the title Update VAMC Policies template with components Update VAMC Policies template with components (v1) Mar 27, 2024
@jilladams jilladams changed the title Update VAMC Policies template with components (v1) VAMC Policies: adopt V1 and V3 components where components are not used Mar 27, 2024
@jilladams jilladams changed the title VAMC Policies: adopt V1 and V3 components where components are not used VAMC Policies: adopt V1 components where components are not used Mar 27, 2024
@laflannery
Copy link
Contributor Author

Telephone moved to #16148

@maxx1128
Copy link

I would rate this a 3 due to the slightly larger scope and the usual risk of breaking tests.

@eselkin
Copy link
Contributor

eselkin commented Apr 23, 2024

I imagine a 2, since all the links internal to the page are centralized content or drupal content that cannot be altered in the code currently.

@jilladams jilladams added the Public Websites Scrum team in the Sitewide crew label May 1, 2024
@randimays randimays self-assigned this May 6, 2024
@randimays
Copy link
Contributor

@laflannery The body content on this page is Drupal content (WYSIWYG blocks), and we can't control the way the links render. I'll still add the Back to Top component on these and adjust the ACs accordingly.

@laflannery
Copy link
Contributor Author

laflannery commented May 6, 2024

Thanks @randimays Thats what I thought but just wanted to be sure I didn't miss anything. Thanks for confirming!

@randimays
Copy link
Contributor

Validated successfully in production. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issues related to accessibility CY24-Q2 Calendar year Q2 2024 priority Facilities Facilities products (VAMC, Vet Center, etc) Public Websites Scrum team in the Sitewide crew sitewide VA.gov frontend CMS team practice area VAMC CMS managed product owned by Facilities team
Projects
None yet
Development

No branches or pull requests

7 participants