Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many VAMC facility services have numerical aliases #16465

Closed
2 of 10 tasks
swirtSJW opened this issue Dec 15, 2023 · 5 comments
Closed
2 of 10 tasks

Many VAMC facility services have numerical aliases #16465

swirtSJW opened this issue Dec 15, 2023 · 5 comments
Assignees
Labels
Defect Something isn't working (issue type) Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status sitewide Technical debt VAMC CMS managed product owned by Facilities team

Comments

@swirtSJW
Copy link
Contributor

swirtSJW commented Dec 15, 2023

Problem statement

It was discovered that many services ended up with aliases that do not reflect their service, only a number. This has no impact on the FE but does create some confusion when you look at the url for a node in the CMS. It would be nice to know the cause, but aliases are not revisioned, so it is hard to know when this occurred or why.

Describe the defect

Slack thread

example : /eastern-oklahoma-health-care/locations/jack-c-montgomery-department-of-veterans-affairs-medical-37
shouldbe: /eastern-oklahoma-health-care/locations/jack-c-montgomery-department-of-veterans-affairs-medical-center/urology

To Reproduce

Steps to reproduce the behavior:

  1. These are detectable by spot checking the alias table for things like -11 or -5

Unfortunately aliases are not tracked as part of revisions so it is not easy to determine when or why this happened.
Possibilities:

  1. these picked up a bad alias when migrated in originally
  2. some bulk operation damaged them.
  3. Created via some inline entity form that creates nodes not fully formed?
  4. ???

The good news is a bulk operation of updating the alias does solve the problem. The bad news is that bulk operation might be too intensive to run on ALL services since we have so many. We would want to try that in a lower environment to make sure it works
The other good news is that this has NO FE implications as these nodes do not have pages of their own on the FE. THis is mainly a cosmetic niceity on the CMS UX.

AC / Expected behavior

A clear and concise description of what you expected to happen.

Desktop (please complete the following information if relevant, or delete)

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Labels

(You can delete this section once it's complete)

  • Issue type (red) (defaults to "Defect")
  • CMS subsystem (green)
  • CMS practice area (blue)
  • CMS workstream (orange) (not needed for bug tickets)
  • CMS-supported product (black)

Team

Please check the team(s) that will do this work.

  • CMS Team
  • Public Websites
  • Facilities
  • User support
  • Accelerated Publishing
@swirtSJW swirtSJW added Defect Something isn't working (issue type) Needs refining Issue status VAMC CMS managed product owned by Facilities team Facilities Facilities products (VAMC, Vet Center, etc) Drupal engineering CMS team practice area labels Dec 15, 2023
@swirtSJW
Copy link
Contributor Author

Upstream issue that points out the defect that aliases are revisionable, but do not create revisions https://www.drupal.org/project/drupal/issues/3321805

@omahane
Copy link
Contributor

omahane commented Dec 21, 2023

Updating the URL aliases took 5:21 seconds on staging.

@swirtSJW
Copy link
Contributor Author

That sounds super quick and not a concern at all.

@omahane
Copy link
Contributor

omahane commented Dec 22, 2023

I ran this on production at 8:00 am CDT and checked the aliases. They appear to be gone.

@omahane
Copy link
Contributor

omahane commented Dec 28, 2023

This can now be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Something isn't working (issue type) Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status sitewide Technical debt VAMC CMS managed product owned by Facilities team
Projects
None yet
Development

No branches or pull requests

4 participants