Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Front End query for regional subsections for VBA Service Region #15956

Closed
2 tasks
xiongjaneg opened this issue Nov 1, 2023 · 8 comments
Closed
2 tasks

Front End query for regional subsections for VBA Service Region #15956

xiongjaneg opened this issue Nov 1, 2023 · 8 comments
Assignees
@maxx1128
Labels
Facilities Facilities products (VAMC, Vet Center, etc) Regional office CMS managed VBA product owned by the Facilities team sitewide VA.gov frontend CMS team practice area

Comments

@xiongjaneg
Copy link
Contributor

xiongjaneg commented Nov 1, 2023 •
edited
Loading

Description or Additional Context

Some VBA services accordions have information driven by a VBA Service Region. See Slack thread

Once a query is identified in #15957, this is to set up the query for regional subsections for VBA Service Region

Resources

Acceptance Criteria

  • Set up query
  • Tested query
@xiongjaneg xiongjaneg added the Needs refining Issue status label Nov 1, 2023
@xiongjaneg
Copy link
Contributor Author

@xiongjaneg to finish stubbing

@xiongjaneg xiongjaneg mentioned this issue Nov 1, 2023
Closed
3 tasks
@xiongjaneg xiongjaneg added VA.gov frontend CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Regional office CMS managed VBA product owned by the Facilities team labels Nov 1, 2023
@maxx1128
Copy link

maxx1128 commented Nov 1, 2023 •
edited
Loading

I would estimate this ticket at a 3. It's adding to an existing query, but it will likely be a more complex query that should be tested on a local GraphQL explorer first.

@xiongjaneg xiongjaneg mentioned this issue Nov 3, 2023
Closed
22 tasks
@xiongjaneg xiongjaneg changed the title Front end query for regional subsections for VBA Service Region Front End query for regional subsections for VBA Service Region Nov 6, 2023
@xiongjaneg xiongjaneg removed the Needs refining Issue status label Nov 6, 2023
@xiongjaneg xiongjaneg mentioned this issue Nov 13, 2023
Closed
2 tasks
@maxx1128 maxx1128 self-assigned this Nov 20, 2023
@maxx1128 maxx1128 mentioned this issue Nov 20, 2023
Merged
2 tasks
@xiongjaneg xiongjaneg mentioned this issue Nov 21, 2023
Closed
16 tasks
@xiongjaneg
Copy link
Contributor Author

carried over to 98

@jilladams
Copy link
Contributor

Noting: Work is in PR and approved, but PR has code conflicts that need to be resolved before merging (FYI @maxx1128 )

@maxx1128
Copy link

@jilladams The code conflicts have been resolved. Once the tests are passing again, it should be good to merge.

@jilladams
Copy link
Contributor

Sounds good! I don't know of reasons not to merge this one.

@jilladams
Copy link
Contributor

@maxx1128 please update ticket today with any news since last comments.

@maxx1128
Copy link

maxx1128 commented Dec 5, 2023

The pull request has been merged, and the ticket status has been updated to PO Review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxx1128 maxx1128

Labels
Facilities Facilities products (VAMC, Vet Center, etc) Regional office CMS managed VBA product owned by the Facilities team sitewide VA.gov frontend CMS team practice area
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maxx1128 @xiongjaneg @jilladams