Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto generate police pages for VAMC systems #15715

Closed
4 of 5 tasks
swirtSJW opened this issue Oct 18, 2023 · 13 comments
Closed
4 of 5 tasks

Auto generate police pages for VAMC systems #15715

swirtSJW opened this issue Oct 18, 2023 · 13 comments
Assignees
Labels
Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Menus [CMS feature] sitewide VAMC police transparency Sub-product of VAMC VAMC CMS managed product owned by Facilities team

Comments

@swirtSJW
Copy link
Contributor

swirtSJW commented Oct 18, 2023

User Story or Problem Statement

Police transparency pages need to be created for each system.

Acceptance Criteria

  • A hook_update_N exists that automatically creates a page for each system
  • A menu item is generated for the proper location (child of ABOUT [SYSTEM NAME], above _____, below ____)
    • CAIA location recommendation
    • Note that CAIA recommendation involves imposing a standard order on the "ABOUT [SYSTEM NAME]" menu subsection. In lieu of imposing that order on all VAMC menus (which I assume is out of scope), we would need to choose a fallback placement rule (e.g. above "Work with us")
  • Account for Lovell exceptionalities (awaiting Tricare feedback) Too big a lift to account for automated creation of Lovell Tricare. It is easy enough to build a tricare version or convert to Federal if they need one in both. For now this only builds a page for Lovell VA.
  • Page is automatically published (shouldn't have any front end user facing affect) Edit - Since we have menues, the menu item would be visible on FE if the page was published. So had to make them draft.

Team

  • Facilities
@swirtSJW swirtSJW added Needs refining Issue status Facilities Facilities products (VAMC, Vet Center, etc) VAMC CMS managed product owned by Facilities team Drupal engineering CMS team practice area labels Oct 18, 2023
@xiongjaneg
Copy link
Contributor

@swirtSJW Michelle and I are inclined not to have any editorial intervention on this page for MVP. We'd like it to be autopublished.

One question:
Jordan's Sketch file includes a Security accordion on the facility page under Prepare for Your Visit that would link to the Police page. Could this accordion be standardize to all facilities? Could this be auto-populated under Prepare for Your Visit?

@davidmpickett davidmpickett added the VAMC police transparency Sub-product of VAMC label Oct 30, 2023
@mmiddaugh
Copy link
Contributor

Will we be able to auto-generate these based on the availability of data for a given facility? In other words, a VA health location shouldn't automatically get a VA police page unless there is data to display. For example, a VA Domiciliary may not have police presence or activity to report.

@davidmpickett
Copy link
Contributor

@xiongjaneg
Copy link
Contributor

@xiongjaneg Consider a Lovell exception for Tricare as Tricare facilities will likely not have VA Police data or will this be like any facility that doesn't have data

@xiongjaneg
Copy link
Contributor

Capturing these questions for the record:

Questions for refinement

  • Does the page need editorial intervention before publishing (or can we auto publish)? Likely no as the CSV could be a starting point that editors could correct later, if needed.
    • There will be a CSV of phone numbers but local editors should be able to edit the numbers because they may be the most accurate source of the phone number.
      • Is this a starting CSV? What's the change management around the editor intervention?
  • What about Lovell? The VA side will likely operate similarly to other VA facilities but Tricare facilities won't be included as Drupal is the source of those facilities.
    • Will Tricare duplicate what's on the VA page?
    • Should Tricare page be unpublished?

@xiongjaneg xiongjaneg removed the Needs refining Issue status label Nov 15, 2023
@xiongjaneg xiongjaneg mentioned this issue Nov 15, 2023
16 tasks
@davidmpickett
Copy link
Contributor

There will be a CSV of phone numbers but local editors should be able to edit the numbers because they may be the most accurate source of the phone number.
Is this a starting CSV? What's the change management around the editor intervention?

No local editor intervention or even putting the phone number fields in Drupal for MVP. Per the content model, the non-emergency phone number csv will be converted to a JSON object and displayed dynamically per facility.

Editor intervention is a post-MVP consideration once the API is available and the content model will be updated then to reflect which data should be controlled via Drupal

@davidmpickett davidmpickett added the Menus [CMS feature] label Nov 28, 2023
@davidmpickett
Copy link
Contributor

davidmpickett commented Nov 28, 2023

@jilladams @xiongjaneg @swirtSJW @omahane - I was following up on the CAIA IA recommendations and realized their guidance may not not be sufficient to answer the second AC. I added this note to the main ticket body.

Not a huge deal, but may require a small bit of conversation when ticket is picked up

@swirtSJW
Copy link
Contributor Author

swirtSJW commented Dec 2, 2023

@davidmpickett I see your reference to a fallback of just above "Work with us" which puts it pretty high on the existing menu structure (which does not match the structure you showed in the description)
image

If the menu is ordered in terms of importance, this placement would indicate this page is pretty important. Is it the second most important of this group?

@swirtSJW
Copy link
Contributor Author

swirtSJW commented Dec 2, 2023

hook update built, and working
image

image

With the exception of menu placement :(

image

@davidmpickett
Copy link
Contributor

@davidmpickett I see your reference to a fallback of just above "Work with us" which puts it pretty high on the existing menu structure (which does not match the structure you showed in the description)

This was not an actual recommendation. It was just an example of what a fallback recommendation might look like.

If the menu is ordered in terms of importance, this placement would indicate this page is pretty important. Is it the second most important of this group?

Per CAIA, the first and last menu positions are the most important, so we want this somewhere in the middle.

@swirtSJW
Copy link
Contributor Author

swirtSJW commented Dec 6, 2023

Still working on a way to place the VA police menu item in the same spot for all 140 menus. I am close, but not there yet.

@swirtSJW
Copy link
Contributor Author

swirtSJW commented Dec 7, 2023

Placement for the menu was placed just above Policies. That was chosen because it has a weight that is significantly different from its siblings so I could reliably place things above it (rather than work with us)
image

This was the most reliable way to pull this off.

The only possible solution to avoid this in the future is to actively separate all items in a menu by at least a value of two.
https://www.drupal.org/project/codit_menu_tools/issues/3406863

@xiongjaneg
Copy link
Contributor

xiongjaneg commented Dec 7, 2023

@swirtSJW If you want to stub a ticket for that potential solution, please do. Which you may have already :)... Stubbed #16413

Closing since subsequent ticket is stubbed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Menus [CMS feature] sitewide VAMC police transparency Sub-product of VAMC VAMC CMS managed product owned by Facilities team
Projects
None yet
Development

No branches or pull requests

5 participants