Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft content spec for VBA Facility content type #13130

Closed
3 tasks done
davidmpickett opened this issue Mar 30, 2023 · 13 comments
Closed
3 tasks done

Draft content spec for VBA Facility content type #13130

davidmpickett opened this issue Mar 30, 2023 · 13 comments
Assignees
Labels
Content model [CMS feature] The bones of the CMS Content CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Regional office CMS managed VBA product owned by the Facilities team sitewide

Comments

@davidmpickett
Copy link
Contributor

davidmpickett commented Mar 30, 2023

Description

AS A Drupal engineer,
I WANT a technical design document
SO THAT there is nothing ambiguous about the implementation requirements.

AS A PO, CMS team member or stakeholder
I WANT to see a detailed content spec
SO THAT I can review the design before implementation

Example artifact

Supporting documents

Artifact

Drupal Content Spec VBA Facility content type

Acceptance Criteria

  • Draft document of content design
  • Review document with Product and Drupal engineering
  • Send to CMS team for review (or wait until all related specs are ready and then schedule a review meeting)
@davidmpickett davidmpickett added Facilities Facilities products (VAMC, Vet Center, etc) Content model [CMS feature] The bones of the CMS Regional office CMS managed VBA product owned by the Facilities team Content CMS team practice area labels Mar 30, 2023
@omahane omahane self-assigned this May 2, 2023
@omahane
Copy link
Contributor

omahane commented May 4, 2023

@kmariepat-cityfriends The following fields are not accounted for in the design:

Field label Machine Name Example values for this Field Field type - label
Non-VA location official name field_non_va_official_name Joint Base Andrews Text (plain)
Non-VA location URL field_non_va_location_url https://www.jba.af.mil Link
Parent office field_office Denver VA Regional Benefit office Entity reference
Shared VHA location field_shared_vha_location PFC Floyd K. Lindstrom Department of Veterans Affairs Clinic (1471) Entity reference

@swirtSJW
Copy link
Contributor

swirtSJW commented May 4, 2023

@kmariepat-cityfriends With the exception of the parent office, it seems like we should be definitely surfacing the others ^^ Parent office I am not sure if that means anything to Veterans. We'd have to consult with RO personell to see if they think it is important.

@kmariepat-cityfriends
Copy link

@swirtSJW @omahane thank you for the guidance and info. I have a meeting with RO managers next week so I will ask there, after confirming with Dave C. that I can, FWIW I think this makes sense too. Also I will let @thejordanwood know to add representation of those fields in her design

@davidmpickett
Copy link
Contributor Author

@kmariepat-cityfriends With the exception of the parent office, it seems like we should be definitely surfacing the others ^^ Parent office I am not sure if that means anything to Veterans. We'd have to consult with RO personell to see if they think it is important.

This already came up in both rounds of research. The Parent Office field is relevant for Satellite Offices because Veterans have an understanding that the Regional Offices tend to be one stop shops. In speaking to Public Contact Staff, we also learned that having that relationship is important for issue escalation.

I work closely with the public contact step in Honolulu and we're on email daily. We meet weekly, sometimes multiple times weekly. So, no, there's there's not a disconnect between this satellite office and the regional office... I would make sure that they understand that I represent the Honolulu Regional Office, and that, any issues that require any type of escalation they know contact the Honolulu Regional Office Public Contact. - Saipan

In #13510 there is conversation around exactly where we would show the Parent Regional Office on Satellite Office pages. Possibly at top of "Other nearby VA locations" or might need a separate header but still be in that vicinity

@omahane
Copy link
Contributor

omahane commented May 5, 2023

@davidmpickett @swirtSJW "Other nearby VA Locations" is one section of the VBA Facility design.
I am unsure how the other facilities will be determined, though. In particular, I'm trying to figure out whether there's some data on the facility itself that will determine this list.

A relevant example is here
https://www.va.gov/charlotte-vet-center/locations/

I know the locations_listing and vet_center_locations_listing have field_office that relates the listing to the facility. What's not clear to me is how the "Other nearby Vet Centers" works. Given that this is similar to the VBA design, I am unclear by what means these will be connected.

@davidmpickett
Copy link
Contributor Author

@davidmpickett @swirtSJW "Other nearby VA Locations" is one section of the VBA Facility design. I am unsure how the other facilities will be determined, though. In particular, I'm trying to figure out whether there's some data on the facility itself that will determine this list.

A relevant example is here https://www.va.gov/charlotte-vet-center/locations/

I know the locations_listing and vet_center_locations_listing have field_office that relates the listing to the facility. What's not clear to me is how the "Other nearby Vet Centers" works. Given that this is similar to the VBA design, I am unclear by what means these will be connected.

This is an outstanding product direction question that @kmariepat-cityfriends and @mmiddaugh are aware of . Not sure if this is going to be manually populated or automagically determined.

For now, fill out fields that you can without knowing the exact implementation (e.g. we know it will be an entity reference, cardinality will probably be capped at 3-5) and leave comments in the stakeholder notes column about need for direction.

@omahane
Copy link
Contributor

omahane commented May 9, 2023

@davidmpickett The artifact has been updated to the extent I can do so.

@omahane
Copy link
Contributor

omahane commented May 10, 2023

@swirtSJW Could you take a look at this? I'd like your feedback/input.

@swirtSJW
Copy link
Contributor

I put this in Slack but adding here for better tracking:

The only issue I am seeing so far and clarifying are the Required: yes?
Whenever something is coming from a migration/external source we NEVER want to make it required. Let's say a field from the source was required but data was empty in the external source, the migration would create a node, but an editor would never be able to save it because of a required field they can not control.

Now when we flip it so that CMS is the source of truth for VBA, then we would have unlock those fields AND make them required

@swirtSJW
Copy link
Contributor

The only other thing that caught my eye this one, but the field already exists so not a big issue and too late-ish.
image

I don't think there was a reason to make a VBA specific field. This could have been the more generic field.

@omahane
Copy link
Contributor

omahane commented May 11, 2023

@davidmpickett This is ready for your review/sign-off.

@omahane
Copy link
Contributor

omahane commented May 23, 2023

@kmariepat-cityfriends This is ready to close.

@swirtSJW
Copy link
Contributor

One note on the doc still has a question about facility status. I created this issue to help refine that particular piece #14546

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content model [CMS feature] The bones of the CMS Content CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Regional office CMS managed VBA product owned by the Facilities team sitewide
Projects
None yet
Development

No branches or pull requests

5 participants