Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty table header cells in data tables in CMS #10133

Open
1 of 10 tasks
Tracked by #18021 ...
laflannery opened this issue Aug 10, 2022 · 9 comments
Open
1 of 10 tasks
Tracked by #18021 ...

Empty table header cells in data tables in CMS #10133

laflannery opened this issue Aug 10, 2022 · 9 comments
Assignees
Labels
a11y-defect-4 Trivial accessibility issue that should be fixed in the next 2-4 sprints accessibility Issues related to accessibility CMS Team CMS Product team that manages both editor exp and devops Drupal engineering CMS team practice area Needs refining Issue status

Comments

@laflannery
Copy link
Contributor

laflannery commented Aug 10, 2022

Description

Still an issue in D10

There are data tables within the CMS that are missing content within the table header cells. Empty table header cells create confusion for users as they may not be able to fully understand the content in the associated table data cells.

Additional Context

List of tables where this was found (may not be the full list of all tables within the CMS):

  • VAMC Facility Edit screen: Hours Table
  • VAMC Facility Non-Clinical Service Edit screen: Hours Table
  • VAMC System Billing and Insurance Edit screen: Hours Table
  • VAMC System Operating Status Edit screen: System-wide alerts Table
  • VAMC System Operating System Edit screen: Facility Operating statuses Table
  • Vet Center Dashboard: Satellite Locations Table
  • Vet Center - Locations List Edit screen: Display additional mobile vet centers Table
  • FAQs Page Edit Screen: Q&As Table
  • Checklist Edit Screen:
    • VA Benefits Hubs Table
    • Contact Information Table
  • FAQs Page Edit Screen:
    • VA Benefits Hubs Table
    • Contact Information Table
  • Image List Edit Screen:
    • VA Benefits Hubs Table
    • Contact Information Table
  • Resources and Support Detail Page Edit Screen:
    • VA Benefits Hubs Table
    • Contact Information Table
  • Step-By-Step Edit Screen:
    • VA Benefits Hubs Table
    • Contact Information Table
  • Video List Edit Screen:
    • VA Benefits Hubs Table
    • Contact Information Table

Screenshot

image

Accessibility Standard

WCAG version 2.0 A, Criterion 1.3.1

Acceptance Criteria

  • Technical review to determine feasibility of adding content to table headers
  • UX/IA to determine what content should say
  • Implementation ticket created

CMS Team

Please check the team(s) that will do this work.

  • Program
  • Platform CMS Team
  • Sitewide Crew
  • ⭐️ Sitewide CMS
  • ⭐️ Public Websites
  • ⭐️ Facilities
  • ⭐️ User support
@laflannery laflannery added Needs refining Issue status CMS Team CMS Product team that manages both editor exp and devops accessibility Issues related to accessibility a11y-defect-4 Trivial accessibility issue that should be fixed in the next 2-4 sprints labels Aug 10, 2022
@laflannery
Copy link
Contributor Author

laflannery commented Jun 13, 2023

Updated description to indicate which ones were remediated by update to office_hours module

@laflannery
Copy link
Contributor Author

@ndouglas Does this need to be broken up into product tickets? It's not just one field type or markup that generates tables this way and would be one ticket?

@ndouglas
Copy link
Contributor

@laflannery

For Benefit Hub(s), are you referring to this interface when you select Benefit Hubs?

Screenshot 2023-10-31 at 11 30 05 AM

Or are you referring to the field as it appears "at rest"?

Screenshot 2023-10-31 at 11 30 46 AM

@laflannery
Copy link
Contributor Author

At rest, the modal doesn't actually have headers (which is neither here nor there at the moment but possibly something that should have another ticket)

@ndouglas
Copy link
Contributor

@laflannery It seems most of these can probably be fixed in a hook that injects "Weight" (or something else?) in the table header for certain fields. I'll defer to @edmund-dunn and @tonytaylor on implementation, though. I think this can all remain in one ticket, unless either of them disagree.

@laflannery
Copy link
Contributor Author

@ndouglas thank you for looking! It's definitely a lower priority but I started going through a lot of tickets today so I just wanted to split this up if I needed to. I really appreciate you taking the time!

@laflannery laflannery added the Drupal engineering CMS team practice area label Nov 3, 2023
@srancour
Copy link
Contributor

This is something that still exists and should still be worked on.

@gracekretschmer-metrostar

@JakeBapple I would like you to do a technical review of this work and @srancour could you do the UX/IA to determine what content should say?

Note, this is work that can be done when you have extra time and have finished any work related to sprint goals.

@bapplejax
Copy link

We may be able to add a site-wide markup solution to empty tds and ths by conditionally adding the aria-label="No value" to any cell in a table with no value. That work would be small in itself but the testing would need to be larger in scope and take up the bulk of the time. Estimated actual dev work would be about an hour to make the changes and spot check locally.

@srancour srancour removed their assignment Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y-defect-4 Trivial accessibility issue that should be fixed in the next 2-4 sprints accessibility Issues related to accessibility CMS Team CMS Product team that manages both editor exp and devops Drupal engineering CMS team practice area Needs refining Issue status
Projects
None yet
Development

No branches or pull requests

6 participants