Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orphaned form label within Editorial Workflow component of the CMS #10113

Closed
3 tasks
laflannery opened this issue Aug 9, 2022 · 4 comments · Fixed by #19796
Closed
3 tasks

Orphaned form label within Editorial Workflow component of the CMS #10113

laflannery opened this issue Aug 9, 2022 · 4 comments · Fixed by #19796
Assignees
Labels
a11y-defect-2 Serious accessibility issue that should be fixed in the next 1-2 sprints accessibility Issues related to accessibility CMS Team CMS Product team that manages both editor exp and devops

Comments

@laflannery
Copy link
Contributor

laflannery commented Aug 9, 2022

Description

Still an issue in D10

In the Editorial workflow component on the edit screens in the CMS, the "Current State" is displayed using the <label> element. However, there is no associated field causing this to be an orphaned form label.

Screenshot

image

Additional Content

There is a different ticket for orphaned form labels in Facilities products on the Read only sections on content.

That ticket also mentioned that I found some D.o issues that might be related to this issue but I'm not sure if they are exactly the same:

Accessibility Standard

WCAG version 2.0 A, Criterion 1.3.1

Acceptance Criteria

  • Determine if this is a core issue
  • Based on above, determine path forward for remediation (i.e. can it be completed within this ticket, do we need to create a new ticket, etc.)
  • Accessibility Review

Previous Team Points

5

@laflannery laflannery added Needs refining Issue status CMS Team CMS Product team that manages both editor exp and devops accessibility Issues related to accessibility a11y-defect-2 Serious accessibility issue that should be fixed in the next 1-2 sprints labels Aug 9, 2022
@laflannery
Copy link
Contributor Author

laflannery commented Feb 17, 2023

This might be hard to update globally.

It might be possible to do some sort of conditional like if no children set as span? How would we keep if from calling the label from the other template?

@ndouglas
Copy link
Contributor

ndouglas commented Oct 5, 2023

Hey team! Please add your planning poker estimate with Zenhub @edmund-dunn @tonytaylor

@srancour
Copy link
Contributor

This is still an issue that should be addressed.

@anantais
Copy link
Contributor

anantais commented Nov 6, 2024

This fix went to github today. Waiting on Steve to QA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y-defect-2 Serious accessibility issue that should be fixed in the next 1-2 sprints accessibility Issues related to accessibility CMS Team CMS Product team that manages both editor exp and devops
Projects
None yet
4 participants