Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CachedAppealService to separate AMA vs Legacy methods #15584

Closed
1 task
yoomlam opened this issue Nov 6, 2020 · 3 comments
Closed
1 task

Refactor CachedAppealService to separate AMA vs Legacy methods #15584

yoomlam opened this issue Nov 6, 2020 · 3 comments
Labels
Feature: generic-queue Priority: Low Reported issue, not a blocker. "Last in" priority for new work. Product: caseflow-queue Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Echo 🐬 Type: Tech-Improvement

Comments

@yoomlam
Copy link
Contributor

yoomlam commented Nov 6, 2020

Description

Refactor CachedAppealService so that methods relating to AMA vs Legacy are in different classes. That would make the service class easier to follow (and reduce the number of lines).

Acceptance criteria

  • Update .reek.yml to remove unnecessary exclusions

Background/context/resources

Motivated by review of Cache hearings related fields selectively #15577.

Technical notes

Common methods used by both AMA and Legacy-related methods

  • regional_office_fields_to_cache
@yoomlam yoomlam added Type: Tech-Improvement Team: Echo 🐬 Priority: Low Reported issue, not a blocker. "Last in" priority for new work. labels Nov 6, 2020
@hschallhorn hschallhorn added Feature: generic-queue Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-queue Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests and removed Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. labels Nov 12, 2020
@hschallhorn
Copy link
Contributor

what is this chart?

1 | 
2 | ||||||
3 | ||||||
5 | 
8 |

Tie goes to the larger estimate!

could keep CachedAppealService as a parent class with the few common methods

Why 2?

  • Straightforward refactor 🤞

Why 3?

  • Code is a bit hairy

@yoomlam
Copy link
Contributor Author

yoomlam commented Dec 9, 2020

May now be easier with PR #15668

@GabbyTISTA
Copy link

moved to https://vajira.max.gov/browse/CASEFLOW-1632

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature: generic-queue Priority: Low Reported issue, not a blocker. "Last in" priority for new work. Product: caseflow-queue Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Echo 🐬 Type: Tech-Improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hschallhorn @yoomlam @GabbyTISTA @ThorntonMatthew