Fix priority logic for appeals with aod motions for appeal attribute caching

[hschallhorn]

Description

Now that AOD motions should be associated with an actual appeal (#14085), we need to adjust the logic for what we consider priority for cached appeal. This is still looking for motions associated with the claimant that were created after the appeal was established.

caseflow/app/jobs/update_cached_appeals_attributes_job.rb

Lines 238 to 247 in 00c4a75

	def aod_status_for_appeals(appeals)
	Appeal.where(id: appeals).joins(
	"left join claimants on appeals.id = claimants.decision_review_id and claimants.decision_review_type = 'Appeal' "\
	"left join people on people.participant_id = claimants.participant_id "\
	"left join advance_on_docket_motions on advance_on_docket_motions.person_id = people.id "
	).where(
	"(advance_on_docket_motions.granted = true and advance_on_docket_motions.created_at > appeals.receipt_date) "\
	"or people.date_of_birth < (current_date - interval '75 years')"
	).pluck(:id)
	end

Acceptance criteria

• Cached appeals are marked as AOD ONLY if one of the following is true
  • aod_based_on_age is true on the appeal
  • The claimant's dob is over 75 years ago
  • The claimant has a granted age base aod motion
  • The appeal has a granted aod motion associated with the appeal
  • The appeal is a cavc remand (not yet implemented)
• Query is written so no N+1 queries (should only produce one db call if possible for alllllllll appeals)
• Job is benchmarked before and after changes to ensure we have not blown up an already long job runtime

Notes

The first 3 AC have a lot of overlap. What should we consider as our source of truth as I assume we don't want to check all 3?

Background/context/resources

Related: #15352

Technical notes

[yoomlam]

what is this chart?

1 | 
2 | 
3 | ||||||
5 | |||
8 | 

Performant caching involves writing efficient SQL.

Why 3?

• This job is known to fail (see #appeals-job-alerts) due to other problems.

Why 5?

• Non-trivial SQL queries
• Ensure we're not introducing unnecessary additional querying

[yoomlam]

Blocked and deprioritized -- see #13175 (comment)