Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent ActiveRecord::RecordNotUnique error on appeals redistribution #15163

Closed
1 task
ajspotts opened this issue Sep 3, 2020 · 2 comments
Closed
1 task
Labels
Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-queue Source: Sentry Alert created because of a Sentry alert Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Echo 🐬 Type: Bug

Comments

@ajspotts
Copy link
Contributor

ajspotts commented Sep 3, 2020

Description

This sentry alert uncovered an issue that in the event that a case is redistributed more than once, it will fail as as currently we are hardcoding the case_id in ScheduleHearingColocatedTask. Instead, we need to update that line to dynamically assign case ids, the most straightforward way being to inject a timestamp e.g. (case_id: "#{appeal.uuid}-attempt-#{Time.zone.now}")

Acceptance criteria

  • Update the send_to_hearings_branch function in ScheduleHearingColocatedTask to dynamically assign case_id

Background/context/resources

Sentry alert
Slack convo

@ajspotts ajspotts added Team: Echo 🐬 Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Source: Sentry Alert created because of a Sentry alert Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests labels Sep 3, 2020
@lomky lomky changed the title Prevent ActiveRecord::RecordNotUnique error on AMA appeals Prevent ActiveRecord::RecordNotUnique error on appeals redistribution Sep 3, 2020
@lomky
Copy link
Contributor

lomky commented Sep 3, 2020

what is this chart?

1 | ||||||||
2 | |||||
3 | 
5 | 
8 | 

git grep attempt1
check in github for other things around attempt1
update the bat team docs

Why 1?

  • change something from 1 to -#{Time.zone.now}

Why 2?

  • Updating batteam wiki and githib tickets that reference attempt1

@hschallhorn
Copy link
Contributor

Updated batteam quick ref https://github.com/department-of-veterans-affairs/appeals-deployment/wiki/Bat-Team-Quick-Ref/2cba4b2ee3416766776fb02baad67d2e4fa9f529
Also update #14705
Also updated #14180
also pinged #14597 to update processing script

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-queue Source: Sentry Alert created because of a Sentry alert Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Echo 🐬 Type: Bug
Projects
None yet
Development

No branches or pull requests

4 participants