Investigate why appeals with VSOs that write IHPs do not have IHP tasks

[hschallhorn]

We have had several users bring up that they expect IHP tasks on certain appeals, but do not see them. We create IHP tasks in a few places, detailed here. If IhpTasksFactory is called before an IHP writing VSO is added to the veteran's case, an IHP task will not automatically be created for them. However, according to sync_tracking_tasks called in UpdateAppellantRepresentationJob, we should be creating IHP tasks for all active appeals that have a new rep that writes IHPs.

# This is a non complete list of vsos that write ihps, but it is a start and will demonstrate the problem
ihp_writing_vsos = Organization.where(type: Vso.name)
poas = BgsPowerOfAttorney.where(poa_participant_id: ihp_writing_vsos.pluck(:participant_id))
appeals = Appeal.where(veteran_file_number: poas.pluck(:file_number), docket_type: [Constants.AMA_DOCKETS.evidence_submission, Constants.AMA_DOCKETS.direct_review])
active_appeals = appeals.where(id: RootTask.active.pluck(:appeal_id))
appeals_without_ihp_task = active_appeals.where.not(id: InformalHearingPresentationTask.pluck(:appeal_id))
appeals_without_ihp_task.count
=> 180

AC

• Investigate why appeals with VSOs that write IHPs do not have IHP tasks
• Fix if within timebox, file a ticket otherwise

[hschallhorn]

Timeboxing to a 3

[hschallhorn]

Batteam thread

uuids = %w"39a2bbe8-837f-46bf-8adf-3114aa223786
  d4e574f5-6e84-422c-be8e-ddf71b44320b
  846c7571-2569-4151-91cd-166fd65c04bd"
appeals = Appeal.where(uuid: uuids)
puts appeals.map(&:tree)
                                         ┌──────────────────────────────────────────────────────────────────────┐
Appeal 82636 (evidence_submission) ───── │ ID      │ STATUS      │ ASGN_BY │ ASGN_TO  │ UPDATED_AT              │
└── RootTask                             │ 985842  │ on_hold     │         │ Bva      │ 2020-06-29 14:52:17 UTC │
    ├── TrackVeteranTask                 │ 985843  │ in_progress │         │ Vso      │ 2020-06-29 14:52:17 UTC │
    ├── DistributionTask                 │ 985844  │ assigned    │         │ Bva      │ 2020-07-09 00:47:35 UTC │
    │   └── EvidenceSubmissionWindowTask │ 985845  │ completed   │         │ MailTeam │ 2020-07-09 00:47:35 UTC │
    └── EvidenceOrArgumentMailTask       │ 1013255 │ completed   │         │ MailTeam │ 2020-07-14 19:23:29 UTC │
                                         └──────────────────────────────────────────────────────────────────────┘
                                         ┌───────────────────────────────────────────────────────────────────────────┐
Appeal 42955 (evidence_submission) ───── │ ID      │ STATUS    │ ASGN_BY     │ ASGN_TO     │ UPDATED_AT              │
└── RootTask                             │ 525961  │ completed │             │ Bva         │ 2020-08-07 18:58:53 UTC │
    ├── TrackVeteranTask                 │ 525962  │ completed │             │ Vso         │ 2020-08-07 18:58:53 UTC │
    ├── DistributionTask                 │ 525963  │ completed │             │ Bva         │ 2020-06-25 16:01:28 UTC │
    │   ├── EvidenceSubmissionWindowTask │ 525964  │ completed │             │ MailTeam    │ 2020-01-14 16:55:31 UTC │
    │   └── TranslationTask              │ 525965  │ completed │             │ Translation │ 2020-06-18 18:19:53 UTC │
    │       └── TranslationTask          │ 622991  │ completed │ VACOHUGHES2 │ VACOBENTOS1 │ 2020-06-18 18:19:53 UTC │
    │           └── TimedHoldTask        │ 695326  │ completed │ VACOBENTOS1 │ VACOBENTOS1 │ 2020-06-17 17:30:30 UTC │
    ├── AodMotionMailTask                │ 746377  │ completed │             │ MailTeam    │ 2020-03-31 19:08:18 UTC │
    │   └── AodMotionMailTask            │ 746378  │ completed │ VACOMCWILJ  │ AodTeam     │ 2020-03-31 19:08:18 UTC │
    │       └── AodMotionMailTask        │ 754679  │ completed │ BVACYEVANS  │ BVACYEVANS  │ 2020-03-31 19:08:18 UTC │
    ├── JudgeAssignTask                  │ 977182  │ completed │             │ BVAMBLACK   │ 2020-06-25 16:11:06 UTC │
    ├── JudgeDecisionReviewTask          │ 977224  │ completed │ BVAMBLACK   │ BVAMBLACK   │ 2020-08-07 17:22:19 UTC │
    │   └── AttorneyTask                 │ 977225  │ completed │ BVAMBLACK   │ BVASECKERMA │ 2020-08-06 18:45:31 UTC │
    └── BvaDispatchTask                  │ 1080445 │ completed │             │ BvaDispatch │ 2020-08-07 18:58:53 UTC │
        └── BvaDispatchTask              │ 1080446 │ completed │             │ VACOCRISPS2 │ 2020-08-07 18:58:53 UTC │
                                         └───────────────────────────────────────────────────────────────────────────┘
                                         ┌─────────────────────────────────────────────────────────────────────┐
Appeal 53651 (evidence_submission) ───── │ ID     │ STATUS      │ ASGN_BY │ ASGN_TO  │ UPDATED_AT              │
└── RootTask                             │ 630034 │ on_hold     │         │ Bva      │ 2020-01-21 15:52:33 UTC │
    ├── TrackVeteranTask                 │ 630035 │ in_progress │         │ Vso      │ 2020-01-21 15:52:33 UTC │
    └── DistributionTask                 │ 630036 │ assigned    │         │ Bva      │ 2020-03-03 13:29:04 UTC │
        └── EvidenceSubmissionWindowTask │ 630037 │ completed   │         │ MailTeam │ 2020-03-03 13:29:04 UTC │
                                         └─────────────────────────────────────────────────────────────────────┘

appeals.map { |appeal| appeal.representatives.any? { |org| org.should_write_ihp?(appeal) } }.uniq
=> [true]

[yoomlam]

More Bat Team ticket 1, ticket 2

active_appeals.count
=> 2476
appeals_without_ihp_task.count
=> 178

[lomky]

Issue identified: Closure of Evidence Windows via the Task Action do not trigger IHP Task process. Filed #15639 to fix!