Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement HearingDay model to represent virtual hearing #14431

Closed
2 tasks
rubaiyat22 opened this issue May 29, 2020 · 0 comments
Closed
2 tasks

Implement HearingDay model to represent virtual hearing #14431

rubaiyat22 opened this issue May 29, 2020 · 0 comments

Comments

@rubaiyat22
Copy link

rubaiyat22 commented May 29, 2020

Description

The current HearingDay model looks as follows:

HearingDay(
  id: integer,
  bva_poc: string,
  created_at: datetime,
  created_by_id: integer,
  deleted_at: datetime,
  judge_id: integer,
  lock: boolean,
  notes: text,
  regional_office: string,
  request_type: string,
  room: string,
  scheduled_for: date,
  updated_at: datetime,
  updated_by_id: integer
)

All of the above fields should be sufficient for a virtual hearing day. All fields except room should be relevant to track for a virtual hearing day since virtual hearings won't have room associated with them.

Currently, the HearingDayAddModal has a checkbox to indicate whether not to assign rooms for hearings (which is checked by default)
Screen Shot 2020-05-29 at 11.25.33 AM.png

HearingDayController uses the param assign_room to determine whether to assign rooms. We can ignore room assignment completely and bypass it here. The room field can stay nil for virtual hearing days.

Acceptance criteria

  • ensure existing tests pass and existing functionality remains unbroken
  • write unit tests for HearingDayController and HearingDay model

Background/context/resources

Technical notes

  • All of our request types are stored as single character here and V is taken by video, we may need to break convention and store virtual as VIRTUAL
  • There's some calculation for generating hearing day schedule where room is taken into account. We might need to look deeper and see if virtual hearing days will be compatible for this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants