Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate that the special issues are not selected along with the "No Special Issues" #13995

Closed
4 tasks
araposo-tistatech opened this issue Apr 14, 2020 · 5 comments · Fixed by #14326
Closed
4 tasks
Assignees
Labels
Feature: generic-queue Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-queue Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Echo 🐬 Type: Enhancement Enhancement to an existing feature User: Attorney User: Judge

Comments

@araposo-tistatech
Copy link

araposo-tistatech commented Apr 14, 2020

User or job story

Job story: When a attorney or judge selects the "No Special Issues" option all other options should be unchecked and disabled so the data captured on the page is accurate.

Acceptance criteria

  • Please put this work behind the feature toggle: special_issues_revamp
  • This feature should be accessible to the following user groups: Attorneys & Judges
  • Include screenshot(s) in the Github issue if there are front-end changes
  • If "No Special Issues" is clicked then all other options are unchecked and disabled

Release notes

Designs

Background/context

The special issues page allows selecting "No Special Issues" along with others. This should not continue as it will cause the data being captured to be inaccurate leading to potential confusion/issues down the line.

Technical notes

Other notes

Resources/other links

Slack Conversation

@yoomlam
Copy link
Contributor

yoomlam commented Apr 14, 2020

Related to #13735. See its PR for a head start.

@geronimoramos
Copy link

Switched up the first component to radio buttons to enable/disable the checkboxes. My first thought was to start with No to disable and prevent users from selecting an issue + selecting no issues while still making the options visible versus revealing them.
Alternately, it can start with yes and if users don’t select an issue they get a validation error.
Alternately, the radio buttons can start unselected but still follow the same behaviors listed above.
image

@geronimoramos geronimoramos self-assigned this Apr 16, 2020
@geronimoramos
Copy link

@araposo-tistatech do we want to park or close this? I took this on a tangent

@araposo-tistatech
Copy link
Author

@geronimoramos can we just get some copy for the error message to display?

@lomky
Copy link
Contributor

lomky commented May 14, 2020

what is this chart?

1 | 
2 | ||||||
3 | ||||||
5 | 
8 | 

Possible fallback to just stopping the user from moving forward with both None and another, if the lift looks unmanagable.

Why 3?

  • Larger front end lift to implement disabling other buttons and unchecking selected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: generic-queue Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-queue Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Echo 🐬 Type: Enhancement Enhancement to an existing feature User: Attorney User: Judge
Projects
None yet
5 participants