Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing AMA cases after case is put on hold #13664

Closed
1 task
yoomlam opened this issue Mar 10, 2020 · 4 comments
Closed
1 task

Fix missing AMA cases after case is put on hold #13664

yoomlam opened this issue Mar 10, 2020 · 4 comments
Assignees
Labels
Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-queue Source: Bat Team Team: Echo 🐬 Type: Bug

Comments

@yoomlam
Copy link
Contributor

yoomlam commented Mar 10, 2020

Description

After a judge puts an AMA case on hold, when they return to their queue view (http://localhost:3000/queue), AMA cases are no longer listed until the page is reloaded/refreshed.

Video: https://www.loom.com/share/f1a89f9e914f405fa42bd113b5d8edec

  • Queue starts with 29 cases
  • After AMA case is put on hold, 17 cases are listed, none of them are AMA cases.
  • After manual refresh, 28 cases are listed. The 1 case put on hold should not be listed.

Acceptance criteria

  • AMA cases are present (without a manual page refresh) in the judges queue view after the judge puts a case on hold

Background/context/resources

https://dsva.slack.com/archives/CHX8FMP28/p1583866360253300

Technical notes

Legacy cases cannot be put on hold, at least in these views.

@yoomlam yoomlam added Product: caseflow-queue Type: Bug Source: Bat Team Team: Echo 🐬 Priority: Low Reported issue, not a blocker. "Last in" priority for new work. labels Mar 10, 2020
@yoomlam
Copy link
Contributor Author

yoomlam commented Mar 10, 2020

Somewhat related to #8095.

@lomky lomky added Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. and removed Priority: Low Reported issue, not a blocker. "Last in" priority for new work. labels Mar 13, 2020
@lomky
Copy link
Contributor

lomky commented Mar 13, 2020

what is this chart?

1 | 
2 | |||||
3 | ||||||||
5 | 
8 | 

full reload gets json, after the task is put on hold its from redux. Somethign is improperly resetting the task list without the AMA tasks.

Why 2?

  • Might be accidentally clearing ama tasks somewhere

Why 3?

  • Because frontend, redux store, ...
  • Time to investigate root cause

@hschallhorn
Copy link
Contributor

😕 Having a hard time reproducing this again. Steps I followed:

  1. Log in as bvaaabshire
  2. Go to their queue
  3. Click an ama case
  4. Select place task on hold from the task action dropdown
  5. Submit the hold
  6. Click back to your queue
  7. Ensure all ama cases appear in queue

Also tested searching for a case so that tasks were not loaded through queue before placing a task on hold. Looks like everything loads correctly.

Thoughts:
This may have been resolved by #14252. One of the changes was that every time queue is loaded, we pull tasks from the back end.

@hschallhorn hschallhorn self-assigned this Sep 29, 2020
@hschallhorn
Copy link
Contributor

Resolved by #14252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-queue Source: Bat Team Team: Echo 🐬 Type: Bug
Projects
None yet
Development

No branches or pull requests

3 participants