Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Motion to Vacate | Do not create De Novo stream without completed judge and attorney tasks #13623

Closed
2 tasks
leikkisa opened this issue Mar 5, 2020 · 0 comments
Closed
2 tasks
Labels
Priority: Low Reported issue, not a blocker. "Last in" priority for new work. Product: caseflow-queue Team: Foxtrot 🦊 Type: Tech-Improvement

Comments

@leikkisa
Copy link
Contributor

leikkisa commented Mar 5, 2020

Description

This ticket is to make the code for creating De Novo streams more robust. The De Novo stream relies on the previous vacate stream having a completed JudgeDecisionReview and Attorney Task. This should always be the case in prod, but let's wrap creation of the de_novo stream in a transaction and throw an error if not, just in case.

Acceptance criteria

  • A de_novo stream is not created if the creation of initial tasks on the stream fails
  • We validate that the judge and attorney from the previously completed task are available

Background/context/resources

Since I believe this would only happen if there is something wrong with the rest of the appeal processing, I'm not sure how we should handle this besides throwing an error. We may want to ask queue or dispatch about it.

Technical notes

See DeNovoStreamCreator

@leikkisa leikkisa added Priority: Low Reported issue, not a blocker. "Last in" priority for new work. Product: caseflow-queue Team: Foxtrot 🦊 Type: Tech-Improvement labels Mar 5, 2020
@leikkisa leikkisa changed the title Motion to Vacate | Do not create De Novo stream unless task creation succeeds Motion to Vacate | Do not create De Novo stream without completed judge and attorney tasks Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Reported issue, not a blocker. "Last in" priority for new work. Product: caseflow-queue Team: Foxtrot 🦊 Type: Tech-Improvement
Projects
None yet
Development

No branches or pull requests

2 participants