Adding attorneys to judge team

[araposo-tistatech]

J. Gosnell is unable to add attorneys to J. White's judge team. Problem statement below:

I created a judge team this morning (456), but then I get the below error when trying to add her attorneys.

JudgeTeam in Team Management page

JudgeTeam Management page errors

Previous investigation:
https://hackmd.io/@hschallh/rk5XrD6EI#Investigation

AC

• Investigate why user cannot add attorneys to judge team they've created
• Any bugs found have an issue filed

[lomky]

What is this chart?

1 | 
2 | |||||
3 | |||||||
5 | 
8 | 

Timebox to a 3.

Could be a 2 if the impersonation immediately shows the error. General optimism.

[yoomlam]

Replicated in dev environment by:

• Log in as TEAM_ADMIN (VACO)
• Go to http://localhost:3000/team_management
• Create new judge team for BVAKKEELING
• Click "Org admin page", which goes to http://localhost:3000/organizations/bvakkeeling/users and I get the following:

Cause:

• The page requests http://localhost:3000/unauthorized, which sends back a {"errors":["Unauthorized"]} response.
  • Likely cause: https://github.com/department-of-veterans-affairs/caseflow/blob/master/app/controllers/organizations/users_controller.rb#L46

user = User.find_by(css_id: "BVAJWHITE")
user.administer_org_users?
=> true
john = User.find_by(full_name: "JOHN GOSNELL")
john.administer_org_users?
=> false

Workaround:
Judge BVAKKEELING can log in and go to http://localhost:3000/organizations/bvakkeeling/users in order to add attorneys to their team.

Sidenote: BVAKKEELING and BVAAABSHIRE return the following:

user.judge_in_vacols?
=> false
user.acting_judge_in_vacols?
=> false

[yoomlam]

@araposo-tistatech Should John be a System Admin?

Here's a list of current System Admins: https://github.com/department-of-veterans-affairs/appeals-deployment/blob/master/ansible/vars/functions-config.yml#L113

Also note the Workaround in the above comment.

Tech note: We check if user is an admin? here.

[yoomlam]

Hunter will create another ticket to address permission consistency:

Access to the team management page/access to create a team/access to view that team’s management page/access to modify members of a team should be the same

FYI: John's comment:

It seems strange that I can create a team for a VLJ but can't add attorneys to it.

See thread: https://dsva.slack.com/archives/CJL810329/p1584449274369300?thread_ts=1584373721.352800&cid=CJL810329