Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate fast_jsonapi #12710

Closed
pkarman opened this issue Nov 14, 2019 · 1 comment
Closed

Evaluate fast_jsonapi #12710

pkarman opened this issue Nov 14, 2019 · 1 comment
Assignees
@ferristseng
Labels
Eng: Backend Work Group backend engineering task Team: Tango 💃 Type: Tech-Improvement

Comments

@pkarman
Copy link
Contributor

pkarman commented Nov 14, 2019

The existing Netflix gem appears to be abandoned and a new fork has sprung up.

We should monitor this new fork and consider switching.
@ferristseng ferristseng self-assigned this May 15, 2020
@ferristseng ferristseng mentioned this issue May 15, 2020
Closed
@ferristseng
Copy link
Contributor

ferristseng commented May 18, 2020 •
edited
Loading

Tabling for now because this has a change that breaks a test for one of the APIs that supports an external team (spec.requests.api.v3.decision_review.higher_level_reviews_controller_spec).

This is the PR that introduces that change:

jsonapi-serializer/jsonapi-serializer#32

The fork also deprecates the serialized_json method, but it should be pretty straight-forward to replace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferristseng ferristseng

Labels
Eng: Backend Work Group backend engineering task Team: Tango 💃 Type: Tech-Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update fast_jsonapi gem department-of-veterans-affairs/caseflow
3 participants
@pkarman @ferristseng @ThorntonMatthew