From ba5ce6b59c614eb5ebcddb9e3d9a34c3e0217725 Mon Sep 17 00:00:00 2001
From: mierenmanz <christiaanmens@gmail.com>
Date: Tue, 9 Jan 2024 16:58:56 +0100
Subject: [PATCH] perf: Optimize arrays by destructuring and by allocating
 space upfront correctly

---
 src/array/array.ts | 28 +++++++++++++++-------------
 1 file changed, 15 insertions(+), 13 deletions(-)

diff --git a/src/array/array.ts b/src/array/array.ts
index fe11b32..14291a8 100644
--- a/src/array/array.ts
+++ b/src/array/array.ts
@@ -7,11 +7,11 @@ export class ArrayType<T> extends UnsizedType<T[]> {
 
   readPacked(dt: DataView, options: Options = { byteOffset: 0 }): T[] {
     if (this.length === 0) return [];
-    const result = [];
-    result.length = this.length;
+    const result = new Array(this.length);
+    const { type } = this;
 
-    for (let i = 0; i < this.length; i++) {
-      result[i] = this.type.readPacked(dt, options);
+    for (let i = 0; i < result.length; i++) {
+      result[i] = type.readPacked(dt, options);
       // No need for the increment offset. This is handled by the `type.readPacked` function
     }
 
@@ -20,15 +20,15 @@ export class ArrayType<T> extends UnsizedType<T[]> {
 
   read(dt: DataView, options: Options = { byteOffset: 0 }): T[] {
     if (this.length === 0) return [];
-    const result: unknown[] = [];
-    result.length = this.length;
+    const result = new Array(this.length);
+    const { type } = this;
 
-    for (let i = 0; i < this.length; i++) {
-      result[i] = this.type.read(dt, options);
+    for (let i = 0; i < result.length; i++) {
+      result[i] = type.read(dt, options);
       // No need for the increment offset. This is handled by the `type.read` function
     }
 
-    return result as T[];
+    return result;
   }
 
   writePacked(
@@ -41,8 +41,9 @@ export class ArrayType<T> extends UnsizedType<T[]> {
     }
     if (value.length === 0) return;
 
-    for (let i = 0; i < this.length; i++) {
-      this.type.writePacked(value[i], dt, options);
+    const { type } = this;
+    for (let i = 0; i < value.length; i++) {
+      type.writePacked(value[i], dt, options);
       // No need for the increment offset. This is handled by the `type.writePacked` function
     }
   }
@@ -57,8 +58,9 @@ export class ArrayType<T> extends UnsizedType<T[]> {
     }
     if (value.length === 0) return;
 
-    for (let i = 0; i < this.length; i++) {
-      this.type.write(value[i], dt, options);
+    const { type } = this;
+    for (let i = 0; i < value.length; i++) {
+      type.write(value[i], dt, options);
       // No need for the increment offset. This is handled by the `type.write` function
     }
   }