imports from deno.json causing deno(import-prefix-missing) in multi-root workspaces

[KrofDrakula]

To Reproduce

NOTE: This works when opening a deno project in an exclusive VS Code window. Using this in a multi-root project breaks.

After enabling Deno for the workspace, use the following deno.json configuration:

{
  "imports": {
    "streams/": "https://deno.land/[email protected]/streams/"
  }
}

In a file in the workspace, try importing the bare identifier:

import { TextLineStream } from "streams/text_line_stream.ts";
new TextLineStream(); // just to avoid the warning

Running this file with Deno works as expected, so the import identifier works.

Expected behavior

Import maps should resolve using the LSP in the editor to match how Deno runs.

Screenshots

Versions

vscode: 1.77.3
deno: 1.33.1
extension: 3.17.0

[KonghaYao]

Hello, when I encountered this issue, I checked the official documentation and solved it in this way.

[KrofDrakula]

@KonghaYao imports within deno.json are detected automatically without having to set that configuration value. The problem is not in a single-root workspace like you have in your example — I've already mentioned this in the original description.

The problem are multi-root workspaces.

[jeslinmx]

Hi @KrofDrakula,

Can I check if you performed any special configuration to allow this to work in a single-root workspace? Based on the comment by @KonghaYao, #718, #805, #833, and my own usage, it seems to be broken there as well.

[KrofDrakula]

@jeslinmx No, I just opened a new window (which I guess creates a blank workspace that I don't save) and the Deno project within in as a folder, no special configuration necessary for me.

[leighmcculloch]

NOTE: This works when opening a deno project in an exclusive VS Code window. Using this in a multi-root project breaks.

This issue happens in another case: when a new window is opened for an empty directory, when building a new single-root project. After adding the deno.json file with an import, the same error displays about import prefixes. The deno extension fails to pickup the imports from the deno.json file. Reloading the window gets it working again.

[bartlomieju]

Thanks for the report folks. Do you still experience these problems with Deno v1.35? There were several improvements to the import map handling in the LSP and I'm wondering if this problem still persists.

[leighmcculloch]

I'm experiencing these problems with Deno v1.35.0, Deno VSCode Extension v3.19.1. Note I don't see this error when building with Deno v1.35.0 on the command line. I only see the issue in VSCode.

[luisfontes]

Experiencing the same issue on Deno v1.35.0. I had it "working" by using
"deno.config": "./path/to/folder/deno.json",
in the code-workspace file. Not a fix though

[kaiba42]

+1 on this issue. I've got a limited understanding, but perhaps it's worthwhile to consider enabling the deno.importPath setting in .vscode/settings.json files within the folders specified in a multi-root workspace (.vscode/projects.code-workspace)

For example

// workspace/.vscode/projects.code-workspace
{
  "folders": [
    {
      "name": "Workspace",
      "path": "../"
    },
    {
      "name": "Project 1",
      "path": "../project1"
    },
    {
      "name": "Project 2",
      "path": "../project2"
    }
  ],
  "settings": {
    // Deno
    "deno.enable": true,
    "deno.enablePaths": ["./project1", "./project2"],
    "deno.unstable": true,
    "deno.suggest.imports.autoDiscover": true,
    "deno.lint": true,
    "deno.path": "./.devenv/profile/bin/deno",
    // -- This doesn't work today because it can only be specified for a single project --
    // "deno.importMap": "./project1/deno.jsonc",
  }
}

// workspace/project1/.vscode/settings.json
{
    "deno.enable": true,
    "deno.importPath": "./deno.jsonc" // <----------- ADD SUPPORT FOR THIS
    "[typescript]": {
        "editor.defaultFormatter": "denoland.vscode-deno"
    }
}

[nayeemrmn]

Closing in favour of #787.