Support formatting json with comments

[matklad]

I have the following in my VsCode's settings.json (which is a "json-with-comments file despite the extension"):

    "[json]": {
        "editor.defaultFormatter": "denoland.vscode-deno"
    },
    "[jsonc]": {
        "editor.defaultFormatter": "denoland.vscode-deno"
    },

However, if I try to format it I get

It feels like this should just work, and perhaps there's some config somewhere missing to enable this?

[dsherret]

I'm not sure what's causing that for you because when I try that it works for me :/

(I'm also not sure where this is configured)

[matklad]

Aha, that's very curious. When I open my settings.json as a file, formatting works. However, if I open it via Ctrl+Shift+P > Open User Settings (JSON), then I see the above dialog. So it looks like vscode bug

[bartlomieju]

Hey @matklad, have you experience the same problem again? I'm not sure if we should investigate it on our side or if that's been fixed.

[bartlomieju]

Please see #860 (comment)