Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(url): remove @std/url #5630

Closed
wants to merge 2 commits into from
Closed

BREAKING(url): remove @std/url #5630

wants to merge 2 commits into from

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Aug 5, 2024

See #5530 for background.

@github-actions github-actions bot added the url label Aug 5, 2024
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.44%. Comparing base (259ce6d) to head (09c7976).
Report is 140 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5630      +/-   ##
==========================================
- Coverage   96.44%   96.44%   -0.01%     
==========================================
  Files         468      461       -7     
  Lines       38221    38150      -71     
  Branches     5542     5542              
==========================================
- Hits        36864    36793      -71     
  Misses       1315     1315              
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua marked this pull request as ready for review August 6, 2024 09:35
@iuioiua iuioiua requested a review from kt3k as a code owner August 6, 2024 09:35
@kt3k
Copy link
Member

kt3k commented Aug 6, 2024

I'd like to land this after we addressed #5537

If we address #5537, then the deprecation message doesn't need to mention path/poxix

@iuioiua
Copy link
Contributor Author

iuioiua commented Aug 26, 2024

Closing until we make the appropriate changes in @std/path.

@iuioiua iuioiua closed this Aug 26, 2024
@iuioiua iuioiua deleted the remove-url branch August 26, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants