fix(node): vendor readable-stream from esm.sh #2584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
force-pushed
the
readable-stream
branch
3 times, most recently
from
3cc8ac3 to
8bc6aa5
Compare
cjihrig
force-pushed
the
readable-stream
branch
2 times, most recently
from
901bf22 to
7b9b71a
Compare
cjihrig
force-pushed
the
readable-stream
branch
from
7b9b71a to
8761118
Compare
cjihrig
force-pushed
the
readable-stream
branch
from
de88c82 to
c69f914
Compare
bartlomieju
reviewed
Aug 31, 2022
There was a problem hiding this comment.
Massive effort @cjihrig, thank you so much for looking into this. This looks mostly good to me and I'm waiting eagerly for fixes in readable-stream that will allow us to remove even more code. Could you add some README file on how to update node/_stream.js file?
kt3k
reviewed
Sep 2, 2022
| npm. To update the code, run the following command: | ||
|
|
||
| ``` | ||
| deno run -A --unstable node/_tools/vendor_readable_stream.ts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening as a draft PR to see how the CI goes while I work on a script to automate the vendoring process.