Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std/node: add net module #666

Closed
EvanHahn opened this issue May 14, 2020 · 10 comments
Closed

std/node: add net module #666

EvanHahn opened this issue May 14, 2020 · 10 comments

Comments

@EvanHahn
Copy link
Contributor

For completeness, we should add a polyfill for Node's net module.

@ebebbington
Copy link

Is it acceptable for a std/node polyfill to only implement part of the module? eg just net.Socket is implemented and there's a notice in the readme saying "Only .Socket is implemented at this moment in time"

I might try work on this if no one else is?

@guybedford
Copy link
Contributor

@ebebbington yes it's absolutely fine to just create a partial implementation and this is what is done for the browser and in Deno already for many cases, often with just a stub function with a todo marked. A contribution would be most welcome.

@ebebbington
Copy link

Alright i'll try work on it when i can, but i'll note that if anyone else is wishing to tackle this issue, feel free as i don't have all the spare time in the world just lying around :P (ie it will take some time)

@guybedford
Copy link
Contributor

This is open source, that is assumed :)

@pavel-kolesnikov
Copy link

The net module is needed for rethinkdb clients (all of them, for reference rethinkdb/rethinkdb-ts#89).

Current implementations are tied to net module; npm to ES module providers like jspm, esm.sh, etc can not or not interested to support Deno specifics.

@cmorten
Copy link
Contributor

cmorten commented Sep 8, 2021

Started up on this - wip available at cmorten#2. Shout if already working on it and will stop to avoid duplicating effort!

Started from scratch, but using #694 to inform implementation / types as I go.

@bartlomieju
Copy link
Member

@cmorten I'm pretty sure no one is working on it, glad that you picked it up - it's will be a major achievement to get compatiblity with net module.

@ebebbington
Copy link

Started up on this - wip available at cmorten#2. Shout if already working on it and will stop to avoid duplicating effort!

Started from scratch, but using #694 to inform implementation / types as I go.

Nice!:) I pretty much just got as far as porting the us code for Socket and Server to TS I believe, only primordial usage and tests were left to address

@jcs224
Copy link
Contributor

jcs224 commented Oct 12, 2021

Don't see it linked here but

image

#1375

@kt3k
Copy link
Member

kt3k commented Oct 12, 2021

Right! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants