Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(snapshot): do not commit wrong snapshot #2128

Closed
kt3k opened this issue Apr 20, 2022 · 1 comment · Fixed by #2179
Closed

test(snapshot): do not commit wrong snapshot #2128

kt3k opened this issue Apr 20, 2022 · 1 comment · Fixed by #2179

Comments

@kt3k
Copy link
Member

kt3k commented Apr 20, 2022

ref #2039

Currently we intentionally commit some wrong snapshots in testing/__snapshot__ to test assertSnapshot, and that means we can't use --update option for updating that snapshot. We need to somehow fix this to avoid the maintenance difficulties
@bcheidemann bcheidemann mentioned this issue Apr 23, 2022
Closed
@bcheidemann bcheidemann mentioned this issue May 2, 2022
Merged
@bcheidemann
Copy link
Contributor

@kt3k This is fixed in #2179 😊

@kt3k kt3k closed this as completed in #2179 May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(testing/snapshot): Add "assertSnapshot" options overload bcheidemann/deno_std
2 participants
@kt3k @bcheidemann