Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress spinner animation on non-interactive shells cause a lot of spam #172

Open
csvn opened this issue Aug 24, 2023 · 0 comments · May be fixed by #313
Open

Progress spinner animation on non-interactive shells cause a lot of spam #172

csvn opened this issue Aug 24, 2023 · 0 comments · May be fixed by #313
Labels
enhancement New feature or request

Comments

@csvn
Copy link

csvn commented Aug 24, 2023

When running deployctl deploy --project my-project main.ts where previously printed lines cannot be replaced, deployctl will cause a lot of spam. As an example, when running this command on Gitlab CI:

⠹ Uploading 1555 assets... (99.8%)
⠸ Uploading 1555 assets... (99.8%)
⠼ Uploading 1555 assets... (99.8%)
⠴ Uploading 1555 assets... (99.9%)
⠦ Uploading 1555 assets... (99.9%)
⠧ Uploading 1555 assets... (99.9%)
⠇ Uploading 1555 assets... (99.9%)
⠏ Uploading 1555 assets... (99.9%)
⠋ Uploading 1555 assets... (99.9%)
⠙ Uploading 1555 assets... (99.9%)
⠹ Uploading 1555 assets... (99.9%)
⠸ Uploading 1555 assets... (99.9%)
⠼ Uploading 1555 assets... (99.9%)
⠴ Uploading 1555 assets... (100.0%)

In the job I checked, there was 1400+ lines of progress for upload. And most of them seemed to have unchanged percentage, where only the symbol at the beginning was changing.

It would be great if deployctl could auto-detect when the shell/terminal/stdout is non-interactive, and automatically change to either remove remove progress entirely, only log when % changes, or log in an interval.

@jeiea jeiea linked a pull request Jun 3, 2024 that will close this issue
@magurotuna magurotuna added the enhancement New feature or request label Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants