Do deeper traversal #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We setup CLA checker, please open a new PR |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5
There are some annoyances with how Rust's default trait method inheritance works. Implementing the one of AstTraverser methods in the rule will override the default trait method, and thus stop walking. Because Rust has no way to call the default trait method from an implementor (https://www.reddit.com/r/rust/comments/3uvfgx/how_to_call_default_trait_method/), the implementor will have to copy and paste the default trait code into their method (or we change the structure of AstTraverser to have a
walk_*andsuper_walk_*method, where the default ofwalk_*is to callsuper_walk_*), to not stop the traversal. This is especially annoying for expressions, because they can be deeply nested in each other.