Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] walk_expression is only called for top level expressions. #5

Closed
lucacasonato opened this issue Mar 29, 2020 · 2 comments
Closed

[bug] walk_expression is only called for top level expressions. #5

lucacasonato opened this issue Mar 29, 2020 · 2 comments

Comments

@lucacasonato
Copy link
Member

lucacasonato commented Mar 29, 2020 •
edited
Loading

walk_expression is not being called for function arguments, if statement tests, variable assignments, switch cases and all other non top level expressions.

The same is true for many other properties.
@kevinkassimo
Copy link
Contributor

Yeah I also noticed this. I changed a bit to make it work with #3

This was referenced Mar 30, 2020
Closed
Closed
@bartlomieju
Copy link
Member

Replaced with swc_ecma_visit swc-project/swc#743

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do deeper traversal luca-rand/deno_lint
Do deeper traversal luca-rand/deno_lint
3 participants
@lucacasonato @bartlomieju @kevinkassimo