Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: command examples use outdated default file_server port #8062

Merged
merged 1 commit into from
Oct 22, 2020
Merged

fix: command examples use outdated default file_server port #8062

merged 1 commit into from
Oct 22, 2020

Conversation

ipriver
Copy link
Contributor

@ipriver ipriver commented Oct 21, 2020

#5226 changed std/http/file_server.ts default port value from 4500 to 4507.

deno/std/http/file_server.ts

Line 326 in 23df1c5

const port = serverArgs.port ?? serverArgs.p ?? 4507;

This PR fixes curl command example here and stdout output in std/http/README.md

bartlomieju
bartlomieju approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ipriver

@bartlomieju bartlomieju merged commit 17eaede into denoland:master Oct 22, 2020
@ipriver ipriver deleted the fix/file_server-default-port branch October 23, 2020 11:26
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
@ipriver
docs: fix command examples use outdated default file_server port (den…
da9a04c 
…oland/deno#8062)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@ipriver
docs: fix command examples use outdated default file_server port (den…
7e05236 
…oland/deno#8062)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@ipriver @caspervonb
docs: fix command examples use outdated default file_server port (den…
d8ed429 
…oland/deno#8062)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@ipriver @caspervonb
docs: fix command examples use outdated default file_server port (den…
8554470 
…oland/deno#8062)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@ipriver @caspervonb
docs: fix command examples use outdated default file_server port (den…
d381e1b 
…oland/deno#8062)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@ipriver @caspervonb
docs: fix command examples use outdated default file_server port (den…
aaae792 
…oland/deno#8062)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@ipriver @caspervonb
docs: fix command examples use outdated default file_server port (den…
36e12f5 
…oland/deno#8062)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@ipriver @denobot
docs: fix command examples use outdated default file_server port (den…
ab1f977 
…oland/deno#8062)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@ipriver @denobot
docs: fix command examples use outdated default file_server port (den…
b79a6a5 
…oland/deno#8062)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ipriver @bartlomieju