Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: remove window.location and self.location #5034

Merged
merged 1 commit into from
May 1, 2020

Conversation

bartlomieju
Copy link
Member

This commit removes "location" global available on "window",
"globalThis" and "self".

Closes #3520

This commit removes "location" global available on "window",
"globalThis" and "self".
@bartlomieju bartlomieju requested a review from ry May 1, 2020 16:46
@ry
Copy link
Member

ry commented May 1, 2020

Please update the manual too

@bartlomieju
Copy link
Member Author

Please update the manual too

Checked before posting; there are no references to location in manual.md

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 6661e7e into denoland:master May 1, 2020
@bartlomieju bartlomieju deleted the remove_location branch May 1, 2020 18:15
SASUKE40 pushed a commit to SASUKE40/deno that referenced this pull request May 7, 2020
This commit removes "location" global available on "window",
"globalThis" and "self".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

window.location should be removed
2 participants