Add missing node os.release() implementation #4065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecyrbe
force-pushed
the
feature/add-os-release
branch
3 times, most recently
from
efce9fd
to
efc9454
Compare
This comment has been minimized.
This comment has been minimized.
bnoordhuis
reviewed
Feb 21, 2020
cli/ops/os.rs
Outdated
| _zero_copy: Option<ZeroCopyBuf>, | ||
| ) -> Result<JsonOp, ErrBox> { | ||
| state.check_env()?; | ||
| let release = sys_info::os_release().unwrap_or_else(|_| "".to_owned()); |
There was a problem hiding this comment.
With Node.js, os.release() on Windows returns "<major>.<minor>.<build>" whereas sys_info::os_release() returns just "<major>.<minor>".
I could PR a change to sys_info adding the build number but we seem to have pinned it to an older version because of Windows breakage in the latest version...
edit: I went ahead and did it anyway: FillZpp/sys-info-rs#47
ecyrbe
force-pushed
the
feature/add-os-release
branch
2 times, most recently
from
55c9d73
to
4d6ce6a
Compare
|
i rebased to fix merge conflicts. |
|
using to_string instead of to_owned (is there a rule of thumb in deno for witch the team prefer to use ?) |
ecyrbe
force-pushed
the
feature/add-os-release
branch
from
1c9dae4
to
77afe3f
Compare
ecyrbe
force-pushed
the
feature/add-os-release
branch
from
77afe3f
to
941c167
Compare
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 21, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Feb 1, 2021
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for one of the tasks from issue #3802 . Adding platform support as it's now there on process impl .
ps: planning to make more of thoses as i learn deno a little more before starting more serious contributions.