[WIP] Try adding signal handler ops #3610
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to add signal handler APIs. This PR depends on tokio::signal::unix module (v0.2.6) and it supports only unix environment.
This PR adds the following JS APIs:
Streaming API
Promise API
and also the stream can be disposed:
The above for-await loop exits after 5000ms.
This PR also adds the following shorthand functions:
These short hand names are inspired by methods of
tokio::signal::unix::SignalKind
.This PR adds 3 ops:
And 1 resource:
remaining tasks:
First I started with the API design loosely following the suggestion by @sholladay at the comment ( #2339 (comment) ), and then I changed it a little inspired by tokio's naming of SignalKind shorthands https://tokio-rs.github.io/tokio/doc/src/tokio/signal/unix.rs.html#82
closes #2339