Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wasm compilation silent failure #2548

Merged
merged 1 commit into from
Jun 20, 2019
Merged

Fix wasm compilation silent failure #2548

merged 1 commit into from
Jun 20, 2019

Conversation

ry
Copy link
Member

@ry ry commented Jun 19, 2019 •
edited
Loading

Fixes #2544

Testing with

./tools/build.py libdeno_test && ./target/debug/libdeno_test --gtest_filter=LibDenoTest.WasmInstantiate

@ry ry changed the title Fix async wasm compilation WIP Fix async wasm compilation Jun 19, 2019
@ry ry force-pushed the wasm_add branch 2 times, most recently from 69423f6 to 086db58 Compare June 19, 2019 23:40
@ry ry changed the title WIP Fix async wasm compilation Fix wasm compilation silent failure Jun 19, 2019
@ry
Fix silent failure of WebAssembly.instantiate()
9fc71d4 
By making WASM compilation synchronous. We'll have to do more work to
make it properly async.
@ry ry requested a review from piscisaureus June 19, 2019 23:45
piscisaureus
piscisaureus approved these changes Jun 20, 2019
View reviewed changes
Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@ry ry merged commit f2c50fa into denoland:master Jun 20, 2019
@ry ry mentioned this pull request Jun 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piscisaureus piscisaureus piscisaureus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WASM instantiation doesn't work properly
2 participants
@ry @piscisaureus