Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ext/timers): Move ext/timers to ext/web #13665

Merged
merged 2 commits into from
Feb 15, 2022
Merged

chore(ext/timers): Move ext/timers to ext/web #13665

merged 2 commits into from
Feb 15, 2022

Conversation

andreubotella
Copy link
Contributor

@andreubotella andreubotella commented Feb 13, 2022 •
edited
Loading

Needed for #13582.

@andreubotella andreubotella marked this pull request as ready for review February 13, 2022 20:00
bartlomieju
bartlomieju reviewed Feb 13, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for me, should we yank all deno_timers releases and somehow redirect users to deno_web

@lucacasonato
Copy link
Member

Looks fine for me, should we yank all deno_timers releases and somehow redirect users to deno_web

No, let's keep them up. We can publish one new release at some point with a README saying to use deno_web now.

lucacasonato
lucacasonato approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucacasonato lucacasonato merged commit 760f4c9 into denoland:main Feb 15, 2022
@andreubotella andreubotella deleted the move-timers-to-web branch February 15, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju left review comments

@lucacasonato lucacasonato lucacasonato approved these changes

@crowlKats crowlKats Awaiting requested review from crowlKats

@littledivy littledivy Awaiting requested review from littledivy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreubotella @lucacasonato @bartlomieju