-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: network panel support for DevTools #11660
Conversation
let inspector = js_runtime.inspector(); | ||
let session_sender = inspector.get_session_sender(); | ||
let deregister_rx = inspector.add_deregister_handler(); | ||
server.register_inspector( | ||
session_sender, | ||
deregister_rx, | ||
main_module.to_string(), | ||
dev_tools_agent, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So unless I missed something we end up the minor caveat here that local sessions won't support the same extended subset as remote sessions get? maybe it'd be better to make the agent own the inspector?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a prototype that will be rewritten. I guess you're still referring to the ability to connect local REPL session to the Devtools?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a prototype that will be rewritten. I guess you're still referring to the ability to connect local REPL session to the Devtools?
Yeah it's low hanging fruit but hypothetically we'd want to expose the local inspector as as a cli binding ala node down the line.
Stale, closing for now, I'll try to revisit this feature in Q1 2022 |
Let's get
fetch
andWebSocket
hooked up to the "Network" panel in Chrome DevTools.