Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deno compile --lite is using wrong URI for denort binary download #9165

Closed
starkpsmichael opened this issue Jan 19, 2021 · 1 comment · Fixed by #9166
Closed

deno compile --lite is using wrong URI for denort binary download #9165

starkpsmichael opened this issue Jan 19, 2021 · 1 comment · Fixed by #9166
Assignees
Labels
bug Something isn't working correctly cli related to cli/ dir high priority
Milestone

Comments

@starkpsmichael
Copy link

starkpsmichael commented Jan 19, 2021

Compiling with deno compile --lite --log-level=debug --unstable mod.ts

Checking https://dl.deno.land/canary/3505823/denort-x86_64-unknown-linux-gnu.zip
DEBUG RS - reqwest::connect:525 - starting new connection: https://dl.deno.land/
DEBUG RS - rustls::client::hs:89 - No cached session for DNSNameRef("dl.deno.land")
DEBUG RS - rustls::client::hs:211 - Not resuming any session
DEBUG RS - rustls::client::hs:598 - Using ciphersuite TLS13_CHACHA20_POLY1305_SHA256
DEBUG RS - rustls::client::tls13:235 - Not resuming
DEBUG RS - rustls::client::tls13:449 - TLS1.3 encrypted extensions: [ServerNameAck, Protocols([PayloadU8([104, 50])])]
DEBUG RS - rustls::client::hs:430 - ALPN protocol is Some(b"h2")
DEBUG RS - rustls::client::tls13:1157 - Ticket saved
DEBUG RS - rustls::client::tls13:1157 - Ticket saved
DEBUG RS - reqwest::async_impl::client:1477 - response '404 Not Found' for https://dl.deno.land/canary/3505823/denort-x86_64-unknown-linux-gnu.zip
Download could not be found, aborting

The URI https://dl.deno.land/canary/3505823/denort-x86_64-unknown-linux-gnu.zip seems to be wrong, it looks like its using a wrong/shortened commit hash, when i use the full commit hash https://dl.deno.land/canary/3505823e20baf961865ddb1d2c74fd420b79f13e/denort-x86_64-unknown-linux-gnu.zip, it founds a download.

Also it would be good, if there is an error, this error would be red in the console. ;D

@lucacasonato
Copy link
Member

You're right. I'll address this.

@lucacasonato lucacasonato added bug Something isn't working correctly cli related to cli/ dir high priority labels Jan 19, 2021
@lucacasonato lucacasonato self-assigned this Jan 19, 2021
@lucacasonato lucacasonato added this to the 1.7.0 milestone Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly cli related to cli/ dir high priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants