Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deno install not working without a version tag #7555

Closed
checkerschaf opened this issue Sep 18, 2020 · 3 comments
Closed

Deno install not working without a version tag #7555

checkerschaf opened this issue Sep 18, 2020 · 3 comments
Labels
bug Something isn't working correctly cli related to cli/ dir

Comments

@checkerschaf
Copy link

Hi,

I just found out that deno install is not working properly if the version of a module has not been specified. Without a version tag only one file is downloaded and therefore the installed program does not work due to missing depedencies.
I think it has something to do with the redirect happening but it's just an idea.

How to reproduce?
This does not work properly:
deno install --allow-net -f -n sherlock https://deno.land/x/sherlock/cli.ts
This does:
deno install --allow-net -f -n sherlock https://deno.land/x/[email protected]/cli.ts

I think the first command should have the same results as manually setting the version to let users always install the newest version automatically.

@lucacasonato lucacasonato added bug Something isn't working correctly cli related to cli/ dir labels Sep 18, 2020
@lucacasonato
Copy link
Member

The issue seems to be that deno bundle does not handle redirects for the entrypoint correctly.

@kitsonk
Copy link
Contributor

kitsonk commented Sep 18, 2020

Which is #3082. Another reason we need to revert the bundle on install until we resolve some bundle issues. I should be able to start looking at all of this very soon.

@lucacasonato
Copy link
Member

Install using bundle was reverted in 1.4.1 which was just released. The redirect issue is a dupe of #3082 like Kitson said.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly cli related to cli/ dir
Projects
None yet
Development

No branches or pull requests

3 participants