Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deno bundle does not bundle imports with @deno-types annotation #6338

Closed
nitsky opened this issue Jun 17, 2020 · 2 comments
Closed

deno bundle does not bundle imports with @deno-types annotation #6338

nitsky opened this issue Jun 17, 2020 · 2 comments
Assignees
Labels
bug Something isn't working correctly cli related to cli/ dir

Comments

@nitsky
Copy link
Contributor

nitsky commented Jun 17, 2020

Hi, I am observing that deno bundle does not bundle imports that have the @deno-types annotation. This may be related to #5665.

// @deno-types="https://unpkg.com/[email protected]/dist/rollup.d.ts"
import { rollup } from 'https://unpkg.com/[email protected]/dist/es/rollup.browser.js'
console.log(rollup)

deno bundle test.js > out.js && deno run out.js

error: Uncaught TypeError: Cannot read property 'rollup' of undefined
            console.log(rollup_browser_js_1.rollup);

If I omit the @deno-types annotation, the out.js file is significantly larger and it works fine.

@kitsonk
Copy link
Contributor

kitsonk commented Jun 17, 2020

Actually this is a duplicate of #4539, just it is also @deno-types as well.

@kitsonk
Copy link
Contributor

kitsonk commented Nov 8, 2020

This was resolved in 1.5 and the way we handle the modules and bundling. The example no longer produces the reported error.

@kitsonk kitsonk closed this as completed Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly cli related to cli/ dir
Projects
None yet
Development

No branches or pull requests

3 participants