Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot bundle deps using "export * as X from..." #4979

Closed
petejodo opened this issue Apr 29, 2020 · 2 comments
Closed

Cannot bundle deps using "export * as X from..." #4979

petejodo opened this issue Apr 29, 2020 · 2 comments

Comments

@petejodo
Copy link

I had a deps file that looks like:

export * as React from "https://dev.jspm.io/react";
export * as ReactDOM from "https://dev.jspm.io/react-dom";

and then the file consuming it...

import { React, ReactDOM } from "./deps.js";
const rootEl = document.getElementById("root");
ReactDOM.render(<div>hello, world</div>, rootEl);

I then ran deno bundle mod.js app.bundle.js. The outputted bundle was missing the react and react-dom dependencies entirely. Changing my deps file to the below fixed the issue:

export { default as React } from "https://dev.jspm.io/react";
export { default as ReactDOM } from "https://dev.jspm.io/react-dom";

I realize they don't mean the exact same thing but for React and ReactDOM, it does. I'm not sure if I'm missing something here. Thanks!

@kitsonk
Copy link
Contributor

kitsonk commented Apr 29, 2020

Duplicate of #4542

@petejodo
Copy link
Author

Oh my apologies, I tried doing a search for it too 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants