-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deno bundle <JavaScript file with triple-slash directive> #4539
Comments
This doesn't have anything to do with it being remote. The bug is related to trying to bundle a JavaScript file with a |
@kitsonk I have changed the title of this issue because I trust what you said. |
Hi, |
No. |
It does look like this happens when using the import { h, render } from "https://cdn.skypack.dev/preact@^10.4.4?dts";
render(h('div', null, 'hello world'), document.body); // tsconfig.json
{
"compilerOptions": {
"jsx": "react",
"jsxFactory": "h",
"lib": [
"DOM",
"DOM.Iterable",
"ESNext"
]
}
} deno bundle -c tsconfig.json ./app.ts ./app.bundle.js The bundle is missing Preact, but works fine if you remove the |
This was fixed in Deno 1.5 |
Steps to reproduce
Run
deno bundle https://deno.land/x/once/index.js
Expected behavior
It prints a bundled JavaScript code
Actual behavior
I didn't try to bundle remote URL at first, instead, I tried bundling a local file (
deps.ts
) that import remote JS file. No compile errors occur, but a runtime error (cannot read property ofundefined
) was thrown when attempting to run it in the browser and in Node.js.The text was updated successfully, but these errors were encountered: