Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request for deno test: Run every single test in isolation; And window.location.pathname should be URL of the test file #4366

Closed
KSXGitHub opened this issue Mar 14, 2020 · 4 comments
Closed

Request for deno test: Run every single test in isolation; And window.location.pathname should be URL of the test file #4366

KSXGitHub opened this issue Mar 14, 2020 · 4 comments
Labels
feat new feature (which has been agreed to/accepted)

Comments

@KSXGitHub
Copy link
Contributor

Reasons

  • Tests should be isolated from each other, to not affect each other.
  • Reduce the differences between running a test (deno test) and running a script (deno run).
  • And to make snapshot testing #3635 (comment) possible.
@ry
Copy link
Member

ry commented Mar 15, 2020

The unit tests in cli/js/tests, I guess you mean? We've discussed it - it seems desirable - but we're also concerned about how long it will take to start up an isolate for each test.

@KSXGitHub
Copy link
Contributor Author

We can run them in parallel.

@KSXGitHub
Copy link
Contributor Author

KSXGitHub commented Mar 15, 2020 •
edited
Loading

To clarify, I am talking about deno test that Deno users use to test their code, not about how Deno itself should be tested.

@KSXGitHub KSXGitHub changed the title Run every single test in isolation; And window.location.pathname should be URL of the test file [deno test] Run every single test in isolation; And window.location.pathname should be URL of the test file Mar 15, 2020
@KSXGitHub KSXGitHub changed the title [deno test] Run every single test in isolation; And window.location.pathname should be URL of the test file Request for deno test: Run every single test in isolation; And window.location.pathname should be URL of the test file Mar 15, 2020
@KSXGitHub KSXGitHub mentioned this issue Mar 15, 2020
Closed
@ry ry added the feat new feature (which has been agreed to/accepted) label Mar 21, 2020
@KSXGitHub KSXGitHub mentioned this issue Apr 6, 2020
Closed
@nayeemrmn nayeemrmn mentioned this issue Oct 7, 2020
Closed
@caspervonb caspervonb mentioned this issue Mar 4, 2021
Closed
@bartlomieju
Copy link
Member

deno test now runs each module in isolation and we currently don't plan to isolate per-test case as the overhead of creating new isolates was too great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feat new feature (which has been agreed to/accepted)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ry @KSXGitHub @bartlomieju