Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect on main module can't be bundled #3082

Closed
kitsonk opened this issue Oct 7, 2019 · 4 comments
Closed

Redirect on main module can't be bundled #3082

kitsonk opened this issue Oct 7, 2019 · 4 comments

Comments

@kitsonk
Copy link
Contributor

kitsonk commented Oct 7, 2019

If the main URL for deno bundle points to a location that provides a redirect, you will get an error something like this:

$ deno bundle https://bit.ly/something bundle.js

error TS5012: Cannot read file 'https://bit.ly/something': Error: assert.

► 
error TS6053: File 'https://bit.ly/something' not found.

► 

Found 2 errors.

But this does not break deno run https://bit.ly/something. (It also demonstrates that some errors in TypeScript don't have a location, and we should avoid printing out the )

@kitsonk kitsonk mentioned this issue Mar 31, 2020
18 tasks
@Caesar2011
Copy link
Contributor

It also demonstrates that some errors in TypeScript don't have a location.

What do you mean by that?

@kitsonk
Copy link
Contributor Author

kitsonk commented May 31, 2020

We have logic for printing diagnostics that assumes all diagnostics have a code point. That logic is flawed.

@Caesar2011
Copy link
Contributor

Caesar2011 commented May 31, 2020

Oh, I understand. That is another issue which is already fixed.

@kitsonk
Copy link
Contributor Author

kitsonk commented Nov 5, 2020

This was resolved in Deno 1.5

@kitsonk kitsonk closed this as completed Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants