Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move GN root into //core/libdeno #2922

Closed
ry opened this issue Sep 11, 2019 · 1 comment · Fixed by #2943
Closed

Move GN root into //core/libdeno #2922

ry opened this issue Sep 11, 2019 · 1 comment · Fixed by #2943
Labels
build build system or continuous integration related

Comments

@ry
Copy link
Member

ry commented Sep 11, 2019

As of #2865, GN is only used now to build V8 and libdeno - the rest of the build is handled by cargo. Therefore it would be nice to not pollute the root directory with various GN/Ninja related directories, symlinks, and files that most will not need to look at.

Basically the following "git mv" actions need to be made:

//build -> //core/libdeno/build
//.gn -> //core/libdeno/.gn
//build_overrides -> //core/libdeno/build_overrides
//buildtools -> //core/libdeno/buildtools

but this will also require adjusting our build scripts and other tooling.

@ry ry added the build build system or continuous integration related label Sep 12, 2019
@chrmoritz
Copy link
Contributor

chrmoritz commented Sep 12, 2019

I'm currently looking into this.

Current progress in: https://github.com/chrmoritz/deno/commits/libdeno_gn_root

=> #2938

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build system or continuous integration related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants