Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Notification on Simple Typo when using Node Buffer #26777

Closed
metalpipemomo opened this issue Nov 8, 2024 · 0 comments · Fixed by #26831
Closed

Error Notification on Simple Typo when using Node Buffer #26777

metalpipemomo opened this issue Nov 8, 2024 · 0 comments · Fixed by #26831
Assignees
Labels
bug Something isn't working correctly lsp related to the language server

Comments

@metalpipemomo
Copy link

Version: Deno 2.0.5

Hey! Unsure if this is intended behaviour or not, but I found myself working with a Node buffer today and whenever I tried to access a member of the Buffer class that wasn't there, a notification within vscode will pop up to yell at me, which I feel is a little excessive considering most of the time its a typo on something that I am actively writing and looking at (and thus noticing). The notification pops up the moment the typo happens, barely a pause or anything in between, I didn't even hit save.

To recreate:

import { Buffer } from 'node:buffer';

const buf = Buffer.fri // <-- innocent typo when writing Buffer.from

I assume this problem isn't exclusive to Node buffers but that is the case that I ran into and can reproduce 100% of the time.

This is the infamous popup:

Screenshot 2024-11-07 at 5 09 34 PM

This is the error when I hit "Go to output":

Screenshot 2024-11-07 at 5 11 22 PM

This actually somehow breaks through vscode's dnd mode as well as me manually turning off the notifications for deno.

My preemptive apologies in case this is actually a vscode issue and not deno's.

@nathanwhit nathanwhit added needs investigation requires further investigation before determining if it is an issue or not lsp related to the language server bug Something isn't working correctly and removed needs investigation requires further investigation before determining if it is an issue or not labels Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly lsp related to the language server
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants