Deno 2 compile doesn't work on sveltekit (error: Module not found runtime/control.js)

[SerJaimeLannister]

Version: deno 2.0.0 (stable, release, x86_64-unknown-linux-gnu) (archlinux)
v8 12.9.202.13-rusty
typescript 5.6.2

Running deno compile on a sveltekit app returns a Module not found runtime/control.js error.

Steps to reproduce

1. Run deno -A npm:create-svelte@latest my-app
   1.1. Click on Sveltekit demo app
   1.2. Yes using typescript syntax
   1.3. Selecting all the 5 options presented in the next step using space bar ) (Add eslint , prettier , vitest etc.)
2. Run cd my-app
3. Run deno install
4. Run deno run dev (shows the expected sveltekit demo app at localhost:5173)
5. Run deno install npm:svelte-adapter-deno
6. Update svelte.config.js file to use Deno adapter:

// svelte.config.js
import adapter from 'svelte-adapter-deno';

export default {
  kit: {
    adapter: adapter()
  }
};

7. Run deno run build to produce build folder and then cd into it (interestingly the last time I ran this it produced a mod.ts file but this time it didn't produce mod.ts I am not exactly sure what has changed since the last time) (this is extremely weird)
8. but still running deno run index.js and giving it the permissions runs the sveltekit demo app
9. Run deno compile build/server/index.js

Output:

error: Module not found "file:///home/test/Projects/deno/my-app/build/runtime/control.js".
    at file:///home/test/Projects/deno/my-app/build/server/index.js:1345:23

[uncomfyhalomacro]

@SerJaimeLannister may i ask if that's really all the content of your file svelte.config.js?

[uncomfyhalomacro]

Okay. I was able to reproduce. Mine is also looking for my-app/build/runtime/control.js hmm

[uncomfyhalomacro]

I find this really weird to be honest. see screenshot below

commands used

• bonk a touch+mkdir utility

[uncomfyhalomacro]

Update: I have a feeling it's looking for this???? (see terminal right)

[SerJaimeLannister]

Were you able to fix this @uncomfyhalomacro

[uncomfyhalomacro]

Were you able to fix this @uncomfyhalomacro

Nope. but i found out how to "make it run". Here is what I did

1. cp -rf '/home/uncomfy/development/projects/.cache/deno/npm/registry.npmjs.org/@sveltejs/kit/2.7.0/src/runtime' runtime
2. cp /home/uncomfy/development/projects/.cache/deno/npm/registry.npmjs.org/svelte-eslint-parser/0.41.1/lib/parser/typescript/types.js server/types.js
3. mkdir -p server page && cp /home/uncomfy/development/projects/.cache/deno/npm/registry.npmjs.org/svelte-eslint-parser/0.41.1/lib/parser/typescript/types.js server/page/types.js
4. deno compila -A index.js && ./build

It's kind of broken but it's also beyond my abilities.

[uncomfyhalomacro]

Nearly was able to. now time to sleep

[SerJaimeLannister]

Hmm , this is kind of "good enough support" and though I appreciate your efforts , I don't think this is worth enough to close this issue

Hopefully someone from the deno team can fix this completely

[yazan-abdalrahman]

I found the main issue and opened a new ticket (#26233) to make it easier to reproduce. So, we can close this and proceed with the new (#26233).

You can do some workarounds for this issue. Go into index.js and remove each JSDoc comments with @param and import(...)statement (e.g., @param {import('./page/types.js').Cookie['options']})

That will make the compile successful.

[SerJaimeLannister]

I found the main issue and opened a new ticket (#26233) to make it easier to reproduce. So, we can close this and proceed with the new (#26233).

You can do some workarounds for this issue. Go into index.js and remove each JSDoc comments with @param and import(...)statement (e.g., @param {import('./page/types.js').Cookie['options']})

That will make the compile successful.

Hey so I did try to remove the as a workaround and it still doesn't work , do I need to remove this jsdoc comment + import on each file of my project?

[yazan-abdalrahman]

jsdoc comment + import on
I removed each '@param {import(' from 'build/server/index.js' and it worked when I compiled it.

[yazan-abdalrahman]

Oh, I found a solution. It's not a bug.

Use --no-check in compile to skip checking the jsdoc.

deno compile --no-check build/server/index.js

@dsherret @bartlomieju

[SerJaimeLannister]

deno compile --no-check build/server/index.js

hey just a minor nitpick , we don't need to have this for build/server/index.js but rather build/index.js

also when I reload , it actually shows asset to be a 404 for some time but just going to a different page makes it work , its very bizarre to say the least and actually gives this error

Error: Not found: /
    at resolve2 (file:///tmp/deno-compile-build/my-app/build/server/index.js:4831:18)
    at resolve (file:///tmp/deno-compile-build/my-app/build/server/index.js:4664:34)
    at Object.handle (file:///tmp/deno-compile-build/my-app/build/server/index.js:4896:71)
    at respond (file:///tmp/deno-compile-build/my-app/build/server/index.js:4662:43)
    at eventLoopTick (ext:core/01_core.js:175:7) {
  status: 404,
  text: "Not Found"
}

sveltekit-test.mp4

[SerJaimeLannister]

Also I think deno should give a warning / custom flag that hey you should do --no-check like how it does for --unstable-sloppy-imports and even then as in the recent issue by @marvinhagemeister (I know this is amature but I tried looking for the issue but I couldn't find the issue created by marvin for --unstable-sloppy-imports) but If I remember correctly it was about asking at the runtime to enable unstable-sloppy-imports.

I think something like this should also be done with deno compile --no-check

also , fixing the issue as of the video could be of some priority

[yazan-abdalrahman]

Version: deno 2.0.0 (stable, release, x86_64-unknown-linux-gnu) (archlinux) v8 12.9.202.13-rusty typescript 5.6.2

Running deno compile on a sveltekit app returns a Module not found runtime/control.js error.

Steps to reproduce

1. Run deno -A npm:create-svelte@latest my-app
   1.1. Click on Sveltekit demo app
   1.2. Yes using typescript syntax
   1.3. Selecting all the 5 options presented in the next step using space bar ) (Add eslint , prettier , vitest etc.)
2. Run cd my-app
3. Run deno install
4. Run deno run dev (shows the expected sveltekit demo app at localhost:5173)
5. Run deno install npm:svelte-adapter-deno
6. Update svelte.config.js file to use Deno adapter:

// svelte.config.js
import adapter from 'svelte-adapter-deno';

export default {
  kit: {
    adapter: adapter()
  }
};

7. Run deno run build to produce build folder and then cd into it (interestingly the last time I ran this it produced a mod.ts file but this time it didn't produce mod.ts I am not exactly sure what has changed since the last time) (this is extremely weird)
8. but still running deno run index.js and giving it the permissions runs the sveltekit demo app
9. Run deno compile build/server/index.js

Output:

error: Module not found "file:///home/test/Projects/deno/my-app/build/runtime/control.js".
    at file:///home/test/Projects/deno/my-app/build/server/index.js:1345:23

I thought your issue in compile (step 9) gives you this error.

error: Module not found "file:///home/test/Projects/deno/my-app/build/runtime/control.js".
    at file:///home/test/Projects/deno/my-app/build/server/index.js:1345:23

and that is mentioned on the label of bug compile

So, to get build without error module not found (that's error occurs in import in commented JSdoc, it's not bug), use --no-check with the compile command

[yazan-abdalrahman]

Also I think deno should give a warning / custom flag that hey you should do --no-check like how it does for --unstable-sloppy-imports and even then as in the recent issue by @marvinhagemeister (I know this is amature but I tried looking for the issue but I couldn't find the issue created by marvin for --unstable-sloppy-imports) but If I remember correctly it was about asking at the runtime to enable unstable-sloppy-imports.

I think something like this should also be done with deno compile --no-check

also , fixing the issue as of the video could be of some priority

I thought an outside bug was the major issue in compile, which was resolved with --no-check.

[yazan-abdalrahman]

@dsherret

[SerJaimeLannister]

oh I see I have to admit my mistake here
to compile the sveltekit project we need to actually build by changing the adapter
and then compiling build/index.js should atleast make it work though with some issues (instead of build/server/index.js) (this was my first time writing reproducible bug so I am sorry )

[SerJaimeLannister]

@yazan-abdalrahman please check the video that I provided , it shows this error

Error: Not found: /
    at resolve2 (file:///tmp/deno-compile-build/my-app/build/server/index.js:4831:18)
    at resolve (file:///tmp/deno-compile-build/my-app/build/server/index.js:4664:34)
    at Object.handle (file:///tmp/deno-compile-build/my-app/build/server/index.js:4896:71)
    at respond (file:///tmp/deno-compile-build/my-app/build/server/index.js:4662:43)
    at eventLoopTick (ext:core/01_core.js:175:7) {
  status: 404,
  text: "Not Found"
}

(this seems a very interesting thing as to why it shows this error )

[yazan-abdalrahman]

That is the mentioned issue and his solution; I can't understand what a current issue, can provide further details.

Recording.2024-10-15.160329.mp4

[SerJaimeLannister]

instead of deno compile build/server/index.js , you have to try deno compile --no-check build/index.js for it to have web app also

also , even when you do that it shows an error on the first reload probably related to how deno runtime probably gets loaded into tmp for the first time

[SerJaimeLannister]

Also a minor nitpick for which I am not sure deserves a full issue is currently we need to use https://github.com/pluvial/svelte-adapter-deno or something along this line & change svelte.config.js because the svelte-adapter-auto doesn't have a default runtime for deno , but this only adds friction I suppose , maybe with deno 2.0 , we can get automatic support for deno in sveltekit?

[yazan-abdalrahman]

Sorry, I couldn't find any errors; maybe I misunderstood your requirements, but I believe you had an issue that was not caused by deno compile.

Recording.2024-10-15.161826.mp4

We should mention deno member; it will be more helpful in clarifying the situation.

@bartlomieju @dsherret