Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad URL scheme on CLI causes crash #2593

Closed
ry opened this issue Jun 27, 2019 · 2 comments
Closed

Bad URL scheme on CLI causes crash #2593

ry opened this issue Jun 27, 2019 · 2 comments

Comments

@ry
Copy link
Member

ry commented Jun 27, 2019

$ deno info htts://deno.land/std/examples/catjson.ts
thread 'tokio-runtime-worker-0' panicked at 'not yet implemented', ../../cli/deno_dir.rs:335:12
note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
thread 'main' panicked at 'internal error: entered unreachable code', ../../third_party/rust_crates/registry/src/github.com-1ecc6299db9ec823/tokio-0.1.21/src/runtime/threadpool/mod.rs:296:26
thread 'tokio-runtime-worker-0' panicked at 'unexpected state while aborting task: Complete', ../../third_party/rust_crates/registry/src/github.com-1ecc6299db9ec823/tokio-threadpool-0.1.14/src/task/mod.rs:216:21
stack backtrace:
   0:        0x108ea8573 - <std::sys::unix::backtrace::tracing::imp::UnwindError as core::fmt::Display>::fmt::h91279d169ccb5b2c
   1:        0x108ea11b2 - std::sys_common::alloc::realloc_fallback::h1ea3e7dd66f55875
   2:        0x108ea4b16 - std::panicking::take_hook::hf5878833b3146ef1
   3:        0x108ea4821 - std::panicking::take_hook::hf5878833b3146ef1
   4:        0x108ea528f - std::panicking::rust_panic_with_hook::h547ea459e27be908
   5:        0x108ea4dbc - std::panicking::begin_panic_fmt::hcacc0f82ca07e29f
   6:        0x108ea4d10 - std::panicking::begin_panic_fmt::hcacc0f82ca07e29f
   7:        0x109cb7186 - <tokio_threadpool::task::Task::run::{{closure}}::Guard<'a> as core::ops::drop::Drop>::drop::h3e4ab556eba4c96c
   8:        0x109cb1369 - tokio_threadpool::pool::state::<impl core::convert::From<tokio_threadpool::pool::state::Lifecycle> for usize>::from::h025a5dce3d6dcb6a
   9:        0x109cb8ece - <tokio_threadpool::shutdown::ShutdownTrigger as core::ops::drop::Drop>::drop::hefa5d5ec07d4e8ed
  10:        0x109cb26eb - <tokio_threadpool::worker::state::Lifecycle as core::fmt::Debug>::fmt::he88a1c5c815cc32d
  11:        0x109cbacf7 - <tokio_threadpool::pool::backup::Handoff as core::fmt::Debug>::fmt::h5e6953337ce61e91
  12:        0x109cb658f - <tokio_threadpool::pool::Pool as core::fmt::Debug>::fmt::h36088954a4cf63c5
  13:        0x108eb4f7e - __rust_maybe_catch_panic
  14:        0x109cad8c5 - <tokio_threadpool::thread_pool::Inner as core::fmt::Debug>::fmt::h17e9019c36f89f75
  15:        0x108eb3d8b - std::sys::unix::thread::Thread::new::h3263e5486f1e27cd
  16:     0x7fff717b42ea - _pthread_body
  17:     0x7fff717b7248 - _pthread_start
thread panicked while panicking. aborting.
Illegal instruction: 4
@bartlomieju
Copy link
Member

Will be resolved by #2572

@bartlomieju
Copy link
Member

Fixed in #2572

$ deno_dev htts://deno.land/std/http/file_server.ts -A
Unsupported scheme "htts" for module "htts://deno.land/std/http/file_server.ts". Supported schemes: [
    "http",
    "https",
    "file",
]

We'll probably want to update the message, but it's not crashing anymore :)

CC @ry

@ry ry closed this as completed Jul 8, 2019
@ry ry reopened this Jul 8, 2019
@ry ry closed this as completed Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants